Finish onboarding ML inference search request / response processors #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
reviewed
Jun 17, 2024
public/pages/workflow_detail/utils/workflow_to_template_utils.ts
Outdated
Show resolved
Hide resolved
public/pages/workflow_detail/utils/workflow_to_template_utils.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Tyler Ohlsen <[email protected]>
owaiskazi19
approved these changes
Jun 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
…182) * Support dynamic workflow generation based on req/resp processors Signed-off-by: Tyler Ohlsen <[email protected]> * Onboard search processors to be dynamically added to template Signed-off-by: Tyler Ohlsen <[email protected]> * one line improvement Signed-off-by: Tyler Ohlsen <[email protected]> * Minor refactorings Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit d0a9846)
ohltyler
added a commit
that referenced
this pull request
Jun 17, 2024
…182) (#183) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit d0a9846) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finishes up what was started in #180. Specifically, it finishes the logic for dynamically generating the ReactFlow workspace nodes/edges, and the workflow template with a
create_search_pipelineworkflow step.workflow_to_template_utilsto generate thecreate_search_pipelinestep with any configured search request and search response processors. Also updates thecreate_indexstep to gracefully handle the cases of no ingest or search pipeline defined, which is allowed in the UI.utilsto generate the dynamic list of nodes/edges in the search flowDemo video showing the workspace flow (template configuration and testing different edge cases of search and ingest pipelines was verified manually - can't test as there is no final implementation of the ML processors on the search side, yet):
screen-capture.45.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.