Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to top-level pages #129

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Apr 8, 2024

Description

This PR improves error handling a few different ways:

  • bubbles up persisted errors as toast notifications at the top-level workflows page and workflow_detail page
  • filters out unnecessary backend errors and hide on the frontend when appropriate. currently, this just means not showing an index_not_found_exception when executing the search workflows API so we don't show errors on a fresh cluster when loading any of the pages, for example

Testing

  • ensured index_not_found_exception is hidden appropriately
  • ensured toasts show for create, save, update, delete workflow failures on the base pages
  • ensured there is no multiple / re-rendering of the toasts (not triggering several toasts for the same error)

Misc

  • improved save state. updating the form only on change for text_field to prevent clicking on the form, and clicking away to automatically set the page to dirty, even if no underlying values were changed
  • improved loading state if rendering a page for a workflow ID that is not found

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler merged commit 292874d into opensearch-project:main Apr 8, 2024
10 checks passed
@ohltyler ohltyler deleted the error-handling branch April 8, 2024 19:07
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 8, 2024
…eption (#129)

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 292874d)
ohltyler added a commit that referenced this pull request Apr 8, 2024
…eption (#129) (#130)

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 292874d)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants