-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple & nested flows #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
…uardrails Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
March 29, 2024 20:26
Signed-off-by: Tyler Ohlsen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 21.67% 21.92% +0.25%
==========================================
Files 54 56 +2
Lines 826 812 -14
Branches 81 82 +1
==========================================
- Hits 179 178 -1
+ Misses 643 630 -13
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
dbwiddis
approved these changes
Apr 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 3eb94a5)
ohltyler
added a commit
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 3eb94a5) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds initial support for persisting multiple flows in a single drag-and-drop ReactFlow workspace - specifically,
Ingest
andSearch
parent/group components.To validate this approach will work with the future drag-and-drop support, a lot of POC work was done. Details on all of those code changes are in the dev branches and list of commits, which is tracked in #118. It is also included in the respective meta issue. For now, we don't include it to keep the commit history and PR simpler and more trackable.
Details of changes:
IngestGroupComponent
andSearchGroupComponent
as available ReactFlow node typesWorkspace
component. It also enhances it by using the ootb hook useReactFlow(). It also opens up the door for adding multiple reactflow contexts on the same view/page, if we want to in the futureWorkspaceComponent
and related components into a singleworkspace_components
dir alongside the added group components.Demo video:
static-with-validation.webm
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.