Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple & nested flows #119

Merged
merged 12 commits into from
Apr 1, 2024
Merged

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Mar 29, 2024

Description

This PR adds initial support for persisting multiple flows in a single drag-and-drop ReactFlow workspace - specifically, Ingest and Search parent/group components.

To validate this approach will work with the future drag-and-drop support, a lot of POC work was done. Details on all of those code changes are in the dev branches and list of commits, which is tracked in #118. It is also included in the respective meta issue. For now, we don't include it to keep the commit history and PR simpler and more trackable.

Details of changes:

  • adds IngestGroupComponent and SearchGroupComponent as available ReactFlow node types
  • updated (currently hardcoded) set of nodes and edges to showcase multiple flows
  • reduces scope of ReactFlow context. Previously, this was done at the global/app level. This reduces it to only the base Workspace component. It also enhances it by using the ootb hook useReactFlow(). It also opens up the door for adding multiple reactflow contexts on the same view/page, if we want to in the future
  • Refactoring WorkspaceComponent and related components into a single workspace_components dir alongside the added group components.
  • Disables node deletion for now
  • Adds placeholder data in the component details section when selecting the parent component

Demo video:

static-with-validation.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.92%. Comparing base (5231f09) to head (840454c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   21.67%   21.92%   +0.25%     
==========================================
  Files          54       56       +2     
  Lines         826      812      -14     
  Branches       81       82       +1     
==========================================
- Hits          179      178       -1     
+ Misses        643      630      -13     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohltyler ohltyler merged commit 3eb94a5 into opensearch-project:main Apr 1, 2024
8 checks passed
@ohltyler ohltyler deleted the blocks branch April 1, 2024 16:08
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 1, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 3eb94a5)
ohltyler added a commit that referenced this pull request Apr 1, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 3eb94a5)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants