-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to ml_configuration in agent response as backend changed #239
switch to ml_configuration in agent response as backend changed #239
Conversation
Signed-off-by: Heng Qian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind add changelog for this change?
Is this change target for 2.16? |
The ml-commons related change #239 (comment) has backported to 2.16, so I think this change should target for 2.16 as well |
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16. |
@raintygao But it cannot be called a feature nor bug fix. Maybe |
Signed-off-by: Heng Qian <[email protected]>
Im okay to this. |
* switch to ml_configuration in agent response as backend changed Signed-off-by: Heng Qian <[email protected]> * Address comments and add changelog Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Add change in release notes Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 913c47b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* switch to ml_configuration in agent response as backend changed Signed-off-by: Heng Qian <[email protected]> * Address comments and add changelog Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Add change in release notes Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 913c47b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
#243) * switch to ml_configuration in agent response as backend changed Signed-off-by: Heng Qian <[email protected]> * Address comments and add changelog Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Add change in release notes Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 913c47b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#242) * switch to ml_configuration in agent response as backend changed Signed-off-by: Heng Qian <[email protected]> * Address comments and add changelog Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Add change in release notes Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 913c47b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The backend ml-commons changed its configuration field from
configuration
toml_configuration
and lead to error.Related change in ml-commons:
opensearch-project/ml-commons#2710
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.