Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to ml_configuration in agent response as backend changed #239

Merged

Conversation

qianheng-aws
Copy link
Contributor

Description

The backend ml-commons changed its configuration field from configuration to ml_configuration and lead to error.

GET /_plugins/_ml/config/os_chat

{
  "config_type": "os_chat_root_agent",
  "ml_configuration": {
    "agent_id": "******************"
  }
}

Related change in ml-commons:
opensearch-project/ml-commons#2710

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind add changelog for this change?

@wanglam
Copy link
Collaborator

wanglam commented Jul 24, 2024

Is this change target for 2.16?

@qianheng-aws
Copy link
Contributor Author

qianheng-aws commented Jul 24, 2024

Is this change target for 2.16?

The ml-commons related change #239 (comment) has backported to 2.16, so I think this change should target for 2.16 as well

@Hailong-am Hailong-am added backport 2.x Trigger the backport flow to 2.x backport 2.16 labels Jul 24, 2024
server/routes/get_agent.ts Outdated Show resolved Hide resolved
Signed-off-by: Heng Qian <[email protected]>
Copy link
Collaborator

@wanglam wanglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raintygao
Copy link
Collaborator

It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16.

@qianheng-aws
Copy link
Contributor Author

It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16.

@raintygao But it cannot be called a feature nor bug fix. Maybe Maintenance ?

@ruanyl ruanyl added the v2.16.0 label Jul 24, 2024
@raintygao
Copy link
Collaborator

It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16.

@raintygao But it cannot be called a feature nor bug fix. Maybe Maintenance ?

Im okay to this.

@Hailong-am Hailong-am merged commit 913c47b into opensearch-project:main Jul 26, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
* switch to ml_configuration in agent response as backend changed

Signed-off-by: Heng Qian <[email protected]>

* Address comments and add changelog

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Add change in release notes

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
(cherry picked from commit 913c47b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
* switch to ml_configuration in agent response as backend changed

Signed-off-by: Heng Qian <[email protected]>

* Address comments and add changelog

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Add change in release notes

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
(cherry picked from commit 913c47b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ruanyl pushed a commit that referenced this pull request Jul 29, 2024
#243)

* switch to ml_configuration in agent response as backend changed

Signed-off-by: Heng Qian <[email protected]>

* Address comments and add changelog

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Add change in release notes

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
(cherry picked from commit 913c47b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Jul 29, 2024
#242)

* switch to ml_configuration in agent response as backend changed

Signed-off-by: Heng Qian <[email protected]>

* Address comments and add changelog

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Add change in release notes

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
(cherry picked from commit 913c47b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x backport 2.16 v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants