feat: text to visualization #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
reviewed
Jul 18, 2024
wanglam
reviewed
Jul 18, 2024
|
|
||
| useEffect(() => { | ||
| const subscription = dataSources.dataSourceService.getDataSources$().subscribe((ds) => { | ||
| setCurrentDataSources(Object.values(ds)); |
There was a problem hiding this comment.
Shall we need to add version decoupling filter here?
There was a problem hiding this comment.
I think it's the same question as shall we add version decoupling for chatbot? I'm open to discuss
There was a problem hiding this comment.
There is a data source picker in the page, I think the data source picker should not display not compatible data sources.
There was a problem hiding this comment.
That depends on if the data source has agent configured.
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
text-to-visualization
branch
from
55f2bcd to
71e54fd
Compare
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
wanglam
reviewed
Jul 23, 2024
wanglam
approved these changes
Jul 23, 2024
Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe
approved these changes
Jul 23, 2024
ruanyl
added
backport 2.x
Hailong-am
approved these changes
Jul 23, 2024
server/routes/get_agent.ts
Outdated
| return response.body.configuration.agent_id; | ||
| } catch (error) { | ||
| const errorMessage = JSON.stringify(error.meta?.body) || error; | ||
| throw new Error('get root agent failed, reason: ' + errorMessage); |
There was a problem hiding this comment.
nit: get root agent this should changed based on input parameter id
Comment on lines
+78
to
+80
| i18n.translate('visualize.vega.failedToGetDataSetErrorDescription', { | ||
| defaultMessage: 'Failed to get data set: ', | ||
| }) + (error.message || error.name), |
There was a problem hiding this comment.
nit: should under dashboardAssistant namespace
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add text to visualization Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 63d9d80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add text to visualization Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 63d9d80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Hailong-am
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add text to visualization Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 63d9d80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add text to visualization Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 63d9d80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests will be added in a separate PR
t2viz.mov
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.