Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSearch build script #119

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Add OpenSearch build script #119

merged 1 commit into from
Sep 7, 2021

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Aug 25, 2021

Description

This change adds the changes required for the plugin to be built & published as part of opensearch.

Openserach-build PR: opensearch-project/opensearch-build#315
###Testing done

  • brazil-build.
  • verified by running the build workflow from opensearch-build repo. ./bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --snapshot --component cross-cluster-replication
  • Verified the artifact published for snapshot and release usecase.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Aug 25, 2021

  • Do you need build.sh? Looks suspiciously like the default one, except for the maven publication (is that required?). If you do, you can put build.sh into scripts/ to keep things better organized if you want.
  • What are the file names from the output of assemble with and without -Dbuild.snapshot=?

@ankitkala
Copy link
Member Author

  • Do you need build.sh? Looks suspiciously like the default one, except for the maven publication (is that required?). If you do, you can put build.sh into scripts/ to keep things better organized if you want.
  • What are the file names from the output of assemble with and without -Dbuild.snapshot=?

It is a replica of the default one. I added the script anticipating changes but ended up not making any change. So yes, it can be removed and we can rely on the default script.

Regarding the file names from assemble, opensearch-cross-cluster-replication-1.1.0-SNAPSHOT.zip and opensearch-cross-cluster-replication-1.1.0.zip is how the zip would be named.

@soosinha
Copy link
Member

Removed build.sh

dblock
dblock previously approved these changes Aug 31, 2021
@dblock
Copy link
Member

dblock commented Aug 31, 2021

Is there no CI running on this repo? When the project i added to the distribution it cannot be breaking the build every day!

@soosinha
Copy link
Member

soosinha commented Sep 1, 2021

@dblock PR for CI workflow: #123

Signed-off-by: Sooraj Sinha <[email protected]>
@ankitkala ankitkala merged commit 6ef2538 into main Sep 7, 2021
@ankitkala ankitkala deleted the opensearch-build branch September 7, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants