Move from common to core.common #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monusingh-1 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1087 +/- ##
============================================
+ Coverage 46.13% 46.22% +0.09%
+ Complexity 634 623 -11
============================================
Files 141 141
Lines 4769 4761 -8
Branches 540 521 -19
============================================
+ Hits 2200 2201 +1
+ Misses 2306 2298 -8
+ Partials 263 262 -1
|
monusingh-1
requested review from
krishna-ggk,
ankitkala,
saikaranam-amazon,
soosinha and
gbbafna
as code owners
ankitkala
reviewed
Jul 21, 2023
| @@ -82,6 +82,7 @@ class BackwardsCompatibilityIT : MultiClusterRestTestCase() { | |||
| ClusterStatus.ONE_THIRD_UPGRADED, ClusterStatus.TWO_THIRD_UPGRADED, ClusterStatus.ROLLING_UPGRADED, | |||
| ClusterStatus.FULL_CLUSTER_RESTART -> verifyReplication() | |||
| ClusterStatus.COMPLETE_SUITE -> {} // Do nothing as all tests have run already | |||
| else -> {throw AssertionError()} | |||
There was a problem hiding this comment.
Can you add an error message here? Same for other places as well.
Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
ankitkala
approved these changes
Jul 21, 2023
soosinha
approved these changes
Jul 21, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1087-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fa7b9c539807e2089f6b8eb23435cd5b9c54c4aa
# Push it to GitHub
git push --set-upstream origin backport/backport-1087-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
monusingh-1
added a commit
to monusingh-1/ccr-dev
that referenced
this pull request
Jul 24, 2023
Keep up with core changes opensearch-project/OpenSearch#8157 move from common to core.common Change kotlin.version "1.8.21" as Class 'org.opensearch.commons.utils.OpenForTesting' was compiled with "1.8.21" version of Kotlin. Ref Set following to use 1.6 as 1.8.21 is not available yet. Checked that other OpenSearch plugins are also doing the same. Set kotlinx-coroutines-core to 1.6.0 set kotlinx-coroutines-test to 1.6.0 Added else in when statements as from Kotlin 1.7 version onward exhaustive list is mandatory. 'when' expression must be exhaustive, add necessary 'else' branch --------- Signed-off-by: monusingh-1 <[email protected]>
5 tasks
monusingh-1
added a commit
that referenced
this pull request
Jul 25, 2023
* Open Upgrade gradle version and remove remaining use of ImmutableOpenMap (#814) Signed-off-by: Monu Singh <[email protected]> * Move from common to core.common (#1087) Keep up with core changes opensearch-project/OpenSearch#8157 move from common to core.common Change kotlin.version "1.8.21" as Class 'org.opensearch.commons.utils.OpenForTesting' was compiled with "1.8.21" version of Kotlin. Ref Set following to use 1.6 as 1.8.21 is not available yet. Checked that other OpenSearch plugins are also doing the same. Set kotlinx-coroutines-core to 1.6.0 set kotlinx-coroutines-test to 1.6.0 Added else in when statements as from Kotlin 1.7 version onward exhaustive list is mandatory. 'when' expression must be exhaustive, add necessary 'else' branch --------- Signed-off-by: monusingh-1 <[email protected]> --------- Signed-off-by: Monu Singh <[email protected]> Signed-off-by: monusingh-1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep up with core changes
opensearch-project/OpenSearch#8157
Change kotlin.version "1.8.21" as
Class 'org.opensearch.commons.utils.OpenForTesting' was compiled with "1.8.21" version of Kotlin. Ref
Set following to use 1.6 as 1.8.21 is not available yet. Checked that other OpenSearch plugins are also doing the same.
Set kotlinx-coroutines-core to 1.6.0
set kotlinx-coroutines-test to 1.6.0
Added else in when statements as from Kotlin 1.7 version onward exhaustive list is mandatory.
'when' expression must be exhaustive, add necessary 'else' branchIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.