-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding missing checkpoint and correcting follower stats test case #1064
Conversation
Signed-off-by: sricharanvuppu <[email protected]>
Follower checkpoint was not being updated based on indexShard.localCheckpoint. This also fixes the "follower stats" integration tests, the test tried to start replication from indices which were not created. |
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
=============================================
- Coverage 73.17% 46.13% -27.05%
+ Complexity 1021 633 -388
=============================================
Files 141 141
Lines 4768 4769 +1
Branches 540 540
=============================================
- Hits 3489 2200 -1289
- Misses 950 2305 +1355
+ Partials 329 264 -65
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1064-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 324b10337ca46c57579186b21f74c9f9d9fd2889
# Push it to GitHub
git push --set-upstream origin backport/backport-1064-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-1064-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 324b10337ca46c57579186b21f74c9f9d9fd2889
# Push it to GitHub
git push --set-upstream origin backport/backport-1064-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9 Then, create a pull request where the |
Description
Follower checkpoint stats are missing in TranslogSequencer.
Corrected test Follower stats
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.