[Backport 2.x] Alerting Enhancements: Alerting Comments (Experimental) #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* initial commit, functional but needs refactoring Signed-off-by: Dennis Toepker <[email protected]> * added lastUpdatedTime to Note object Signed-off-by: Dennis Toepker <[email protected]> * changed name from alert id to entity id Signed-off-by: Dennis Toepker <[email protected]> * import cleanup Signed-off-by: Dennis Toepker <[email protected]> * changing name from Alerting Notes to Alerting Comments Signed-off-by: Dennis Toepker <[email protected]> * misc fixes and cleanup Signed-off-by: Dennis Toepker <[email protected]> * adding unit test coverage Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * misc review-based cleanup Signed-off-by: Dennis Toepker <[email protected]> * added validation exception messages Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> (cherry picked from commit acaa844) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
approved these changes
Jun 10, 2024
eirsep
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport acaa844 from #663.