adding constructor with optional comments indices args #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
requested review from
lezzago,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90,
AWSHurneyt,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
eirsep
reviewed
Jun 10, 2024
| @@ -89,6 +86,29 @@ data class DataSources( | |||
| findingsEnabled = sin.readOptionalBoolean() | |||
| ) | |||
|
|
|||
| @Throws(IOException::class) | |||
There was a problem hiding this comment.
why are we expecting IoException?
Signed-off-by: Dennis Toepker <[email protected]>
eirsep
approved these changes
Jun 10, 2024
eirsep
requested changes
Jun 10, 2024
| @@ -89,6 +86,28 @@ data class DataSources( | |||
| findingsEnabled = sin.readOptionalBoolean() | |||
| ) | |||
|
|
|||
| constructor( | |||
There was a problem hiding this comment.
comments index should be using readOptionalString(), writeOptionalString, null check in parsing etc.
plz incorporate
There was a problem hiding this comment.
updating readOptional and writeOptional, parse adds an empty string placeholder for any comments that don't exist in the XContent, so leaving that be
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
eirsep
approved these changes
Jun 10, 2024
AWSHurneyt
approved these changes
Jun 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
* adding ctor with optional comments indices args Signed-off-by: Dennis Toepker <[email protected]> * removing throws IOException declaration above new ctor Signed-off-by: Dennis Toepker <[email protected]> * making reads and writes optional Signed-off-by: Dennis Toepker <[email protected]> * quick comment change Signed-off-by: Dennis Toepker <[email protected]> * adding test for new ctor Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> (cherry picked from commit bc215fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Jun 10, 2024
* adding ctor with optional comments indices args * removing throws IOException declaration above new ctor * making reads and writes optional * quick comment change * adding test for new ctor --------- (cherry picked from commit bc215fd) Signed-off-by: Dennis Toepker <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <[email protected]>
eirsep
changed the title
eirsep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a breaking change to Security Analytics Plugin caused by #663
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.