Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fix findings API enhancemnts #617

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3f5421f from #611.

* fix findings API enhancemnts

Signed-off-by: Riya Saxena <[email protected]>

* fix klint errors

Signed-off-by: Riya Saxena <[email protected]>

* fix klint errors

Signed-off-by: Riya Saxena <[email protected]>

* fix klint errors

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
(cherry picked from commit 3f5421f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.76%. Comparing base (d936c8f) to head (35fcc81).

Files Patch % Lines
...arch/commons/alerting/action/GetFindingsRequest.kt 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #617      +/-   ##
============================================
- Coverage     72.81%   72.76%   -0.05%     
+ Complexity      869      864       -5     
============================================
  Files           133      133              
  Lines          5870     5850      -20     
  Branches        717      718       +1     
============================================
- Hits           4274     4257      -17     
+ Misses         1281     1278       -3     
  Partials        315      315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riysaxen-amzn riysaxen-amzn merged commit e6cd139 into 2.x Mar 14, 2024
16 of 19 checks passed
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…ject#617)

* fix findings API enhancemnts



* fix klint errors



* fix klint errors



* fix klint errors



---------


(cherry picked from commit 3f5421f)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants