-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added engechas as a maintainer. #593
Merged
eirsep
merged 4 commits into
opensearch-project:main
from
AWSHurneyt:3.0-maintainers-chase
Feb 9, 2024
Merged
Added engechas as a maintainer. #593
eirsep
merged 4 commits into
opensearch-project:main
from
AWSHurneyt:3.0-maintainers-chase
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWSHurneyt
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep and
sbcd90
as code owners
February 9, 2024 00:31
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
============================================
- Coverage 74.02% 74.00% -0.02%
Complexity 890 890
============================================
Files 133 133
Lines 5843 5843
Branches 715 715
============================================
- Hits 4325 4324 -1
Misses 1207 1207
- Partials 311 312 +1 ☔ View full report in Codecov by Sentry. |
peterzhuamazon
approved these changes
Feb 9, 2024
peterzhuamazon
requested changes
Feb 9, 2024
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
force-pushed
the
3.0-maintainers-chase
branch
from
February 9, 2024 01:42
ca579b7
to
cddeaf5
Compare
peterzhuamazon
approved these changes
Feb 9, 2024
eirsep
approved these changes
Feb 9, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/common-utils/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/common-utils/backport-2.x
# Create a new branch
git switch --create backport-593-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 730b1f8b897f170c8ba7ec7a70a691393a8f520e
# Push it to GitHub
git push --set-upstream origin backport-593-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/common-utils/backport-2.x Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added @engechas as a maintainer.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.