Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added engechas as a maintainer. #593

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Added @engechas as a maintainer.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd8ea9b) 74.02% compared to head (cddeaf5) 74.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #593      +/-   ##
============================================
- Coverage     74.02%   74.00%   -0.02%     
  Complexity      890      890              
============================================
  Files           133      133              
  Lines          5843     5843              
  Branches        715      715              
============================================
- Hits           4325     4324       -1     
  Misses         1207     1207              
- Partials        311      312       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt AWSHurneyt force-pushed the 3.0-maintainers-chase branch from ca579b7 to cddeaf5 Compare February 9, 2024 01:42
@eirsep eirsep merged commit 730b1f8 into opensearch-project:main Feb 9, 2024
11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/common-utils/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/common-utils/backport-2.x
# Create a new branch
git switch --create backport-593-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 730b1f8b897f170c8ba7ec7a70a691393a8f520e
# Push it to GitHub
git push --set-upstream origin backport-593-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/common-utils/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-593-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants