Added support for SesAccount #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated Feature to be simple string for future plugin easy addition [Tests] Added unit tests for SesAccount Updated Unit tests for changes Signed-off-by: @akbhatta
joshuali925
reviewed
Aug 12, 2021
| data class SesAccount( | ||
| val awsRegion: String, | ||
| val roleArn: String?, | ||
| val fromAddress: String |
There was a problem hiding this comment.
I remember previously the decision was to only have a text box in UI for SES sender, did this change? are we adding a new config type for SesAccount, and another one for SES?
There was a problem hiding this comment.
SES configuration needs to be taken from UI instead of taking from yaml file hence additional fields. In UI, for the email configuration, customer can either choose SmtpAccount or SesAccount for sender profile.
There was a problem hiding this comment.
i see. also what's the format to specify awsRegion? is there a list of valid strings?
akbhatta
requested review from
anirudha,
dai-chen,
dbbaughe,
lezzago and
zhongnansu
joshuali925
approved these changes
Aug 12, 2021
5 tasks
akbhatta
added a commit
that referenced
this pull request
Aug 13, 2021
* Added support for SesAccount (#54) Also updated Feature to be simple string for future plugin easy addition [Tests] Added unit tests for SesAccount Updated Unit tests for changes Signed-off-by: @akbhatta * Adds legacy chime, slack, custom webhook messages, request/response f (#53) * Adds legacy chime, slack, custom webhook messages, request/response for publishing legacy notifications, and method for executing transport action Signed-off-by: Drew Baugher <[email protected]> * Fixes import and removes username/password that is not used by ISM Signed-off-by: Drew Baugher <[email protected]> * Throws error for toXContent for legacy notification response Signed-off-by: Drew Baugher <[email protected]> * Renames legacy destination types to have legacy prefix Signed-off-by: Drew Baugher <[email protected]> * Obfuscates message to remove from logs in toString method Signed-off-by: Drew Baugher <[email protected]> * Makes destinationt type private and updates places to use getter Signed-off-by: Drew Baugher <[email protected]> * Inlines destination type Signed-off-by: Drew Baugher <[email protected]> * Makes base message content final Signed-off-by: Drew Baugher <[email protected]> * Requires url to be defined in LegacyCustomWebhookMessage for use across transport wire and only writes the full url instead of each individual part Signed-off-by: Drew Baugher <[email protected]> Co-authored-by: Drew Baugher <[email protected]>
zelinh
pushed a commit
that referenced
this pull request
Aug 18, 2022
Also updated Feature to be simple string for future plugin easy addition [Tests] Added unit tests for SesAccount Updated Unit tests for changes Signed-off-by: @akbhatta Signed-off-by: Zelin Hao <[email protected]>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
Also updated Feature to be simple string for future plugin easy addition [Tests] Added unit tests for SesAccount Updated Unit tests for changes Signed-off-by: @akbhatta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for SesAccount
Also updated Feature to be simple string for future plugin easy addition
[Tests]
Added unit tests for SesAccount
Updated Unit tests for changes
Signed-off-by: @akbhatta
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.