Add Notifications SNS model #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
6 tasks
Signed-off-by: Joshua Li <[email protected]>
zhongnansu
reviewed
Aug 9, 2021
src/main/kotlin/org/opensearch/commons/notifications/model/SNS.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Joshua Li <[email protected]>
akbhatta
previously approved these changes
Aug 9, 2021
| init { | ||
| require(SNS_ARN_REGEX.matcher(topicARN).find()) { "Invalid AWS SNS topic ARN: $topicARN" } | ||
| if (roleARN != null) { | ||
| require(IAM_ARN_REGEX.matcher(roleARN).find()) { "Invalid AWS role ARN: $roleARN " } |
There was a problem hiding this comment.
Probably this can be moved to utils as this is required for SES as well
Signed-off-by: Joshua Li <[email protected]>
zhongnansu
approved these changes
Aug 9, 2021
zelinh
pushed a commit
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Zelin Hao <[email protected]>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SNS model required to support SNS channels in Notifications plugin.
Add unit tests.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.