Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors after refactoring of Strings class in core #432

Merged
merged 1 commit into from
May 19, 2023

Conversation

Hailong-am
Copy link
Contributor

Description

Fix build break due to refactoring of Strings in core
opensearch-project/OpenSearch#7508

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #432 (ffe4228) into main (968a23d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #432   +/-   ##
=========================================
  Coverage     72.87%   72.87%           
  Complexity      712      712           
=========================================
  Files           113      113           
  Lines          4711     4711           
  Branches        606      606           
=========================================
  Hits           3433     3433           
  Misses         1024     1024           
  Partials        254      254           
Impacted Files Coverage Δ
...in/java/org/opensearch/commons/InjectSecurity.java 71.92% <ø> (ø)
...earch/commons/authuser/AuthUserRequestBuilder.java 0.00% <ø> (ø)
...ain/java/org/opensearch/commons/authuser/User.java 87.82% <ø> (ø)
...commons/destination/message/LegacyBaseMessage.java 67.44% <ø> (ø)
...ommons/destination/message/LegacyChimeMessage.java 89.47% <ø> (ø)
...estination/message/LegacyCustomWebhookMessage.java 74.68% <ø> (ø)
...ommons/destination/message/LegacyEmailMessage.java 89.47% <ø> (ø)
.../commons/destination/message/LegacySNSMessage.java 0.00% <ø> (ø)
...ommons/destination/message/LegacySlackMessage.java 85.71% <ø> (ø)
.../org/opensearch/commons/destination/util/Util.java 0.00% <ø> (ø)
... and 15 more

@bowenlan-amzn bowenlan-amzn merged commit 9a57fc4 into opensearch-project:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants