Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate security-analytics & alerting for correlation engine #412

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Apr 18, 2023

Description

integrate security-analytics & alerting for correlation engine

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbcd90 sbcd90 requested a review from a team April 18, 2023 21:47
@@ -12,6 +12,7 @@ object AlertingActions {
const val DELETE_MONITOR_ACTION_NAME = "cluster:admin/opendistro/alerting/monitor/delete"
const val GET_FINDINGS_ACTION_NAME = "cluster:admin/opensearch/alerting/findings/get"
const val ACKNOWLEDGE_ALERTS_ACTION_NAME = "cluster:admin/opendistro/alerting/alerts/ack"
const val SUBSCRIBE_FINDINGS_ACTION_NAME = "cluster:admin/opendistro/alerting/findings/subscribe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to cluster:admin/opensearch/alerting/findings/subscribe

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #412 (514fa7a) into main (f7639aa) will decrease coverage by 0.51%.
The diff coverage is 12.82%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #412      +/-   ##
============================================
- Coverage     73.20%   72.69%   -0.51%     
- Complexity      700      701       +1     
============================================
  Files           110      112       +2     
  Lines          4631     4670      +39     
  Branches        610      611       +1     
============================================
+ Hits           3390     3395       +5     
- Misses          985     1019      +34     
  Partials        256      256              
Impacted Files Coverage Δ
...search/commons/alerting/AlertingPluginInterface.kt 39.13% <0.00%> (-7.03%) ⬇️
.../commons/alerting/action/PublishFindingsRequest.kt 0.00% <0.00%> (ø)
...mmons/alerting/action/SubscribeFindingsResponse.kt 0.00% <0.00%> (ø)
...n/org/opensearch/commons/alerting/model/Finding.kt 44.04% <40.00%> (-0.55%) ⬇️
...nsearch/commons/alerting/action/AlertingActions.kt 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 81ddb4b into opensearch-project:main Apr 19, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2023
sbcd90 pushed a commit that referenced this pull request Apr 19, 2023
sbcd90 pushed a commit that referenced this pull request Apr 19, 2023
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants