Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support backend roles in indexMonitorRequest #308

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Nov 2, 2022

Signed-off-by: Ashish Agrawal [email protected]

Description

Support backend roles in indexMonitorRequest

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #308 (14cc9b3) into main (67fda10) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #308      +/-   ##
============================================
+ Coverage     73.39%   73.40%   +0.01%     
- Complexity      697      698       +1     
============================================
  Files           110      110              
  Lines          4574     4580       +6     
  Branches        605      605              
============================================
+ Hits           3357     3362       +5     
- Misses          967      968       +1     
  Partials        250      250              
Impacted Files Coverage Δ
...rch/commons/alerting/action/IndexMonitorRequest.kt 88.23% <66.66%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago merged commit b7ceeec into opensearch-project:main Nov 2, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit b7ceeec)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit b7ceeec)
lezzago added a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit b7ceeec)

Co-authored-by: Ashish Agrawal <[email protected]>
lezzago added a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit b7ceeec)

Co-authored-by: Ashish Agrawal <[email protected]>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
…opensearch-project#309)

Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit b7ceeec)

Co-authored-by: Ashish Agrawal <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…opensearch-project#309)

Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit b7ceeec)

Co-authored-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants