Add support for -Dbuild.version_qualifier. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
dblock
changed the title
dblock
force-pushed
the
add-qualifier-support
branch
from
191d850 to
33b4709
Compare
dblock
changed the title
peternied
previously approved these changes
Mar 9, 2022
|
Building on JDK8 is broken since some upgrades in OpenSearch 2.0, is being removed in #129. |
dblock
force-pushed
the
add-qualifier-support
branch
from
33b4709 to
011ddc3
Compare
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
add-qualifier-support
branch
from
011ddc3 to
1b24d81
Compare
saratvemulapalli
approved these changes
Mar 9, 2022
| } | ||
|
|
||
| allprojects { | ||
| group 'org.opensearch.commons' | ||
| version = opensearch_version - '-SNAPSHOT' + '.0' | ||
| version = opensearch_version.tokenize('-')[0] + '.0' |
There was a problem hiding this comment.
do we really need to tokenize opensearch version ?
There was a problem hiding this comment.
It's things like 1.2.3-alpha1-SNAPSHOT, so we just need the first part left of the - or the entire thing if it's 1.2.3. Do you know a better way to do it?
getsaurabh02
approved these changes
Mar 10, 2022
This was referenced Mar 10, 2022
Merged
zelinh
pushed a commit
that referenced
this pull request
Aug 18, 2022
Signed-off-by: dblock <[email protected]> Signed-off-by: Zelin Hao <[email protected]>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
Signed-off-by: dblock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock [email protected]
Description
Add support for
-Dbuild.version_qualifier=alpha1.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.