Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Model Profile Test #750

Merged
merged 11 commits into from
Dec 6, 2022
Merged

Refactoring Model Profile Test #750

merged 11 commits into from
Dec 6, 2022

Conversation

vibrantvarun
Copy link
Member

Description

Refactoring Model Profile Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vibrantvarun vibrantvarun requested a review from a team December 6, 2022 05:21
@codecov-commenter
Copy link

Codecov Report

Merging #750 (fd4b667) into feature/extensions (71010ca) will decrease coverage by 0.08%.
The diff coverage is 4.87%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feature/extensions     #750      +/-   ##
========================================================
- Coverage                 53.33%   53.25%   -0.09%     
- Complexity                 2658     2661       +3     
========================================================
  Files                       291      291              
  Lines                     16061    16097      +36     
  Branches                   1686     1689       +3     
========================================================
+ Hits                       8566     8572       +6     
- Misses                     6877     6908      +31     
+ Partials                    618      617       -1     
Flag Coverage Δ
plugin 53.25% <4.87%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java 0.00% <0.00%> (ø)
...opensearch/ad/rest/RestValidateDetectorAction.java 0.00% <0.00%> (ø)
.../java/org/opensearch/ad/util/RestHandlerUtils.java 66.15% <100.00%> (+0.52%) ⬆️
...ava/org/opensearch/ad/model/TimeConfiguration.java 100.00% <0.00%> (ø)
...c/main/java/org/opensearch/ad/util/ParseUtils.java 60.57% <0.00%> (+0.14%) ⬆️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 70.19% <0.00%> (+0.64%) ⬆️
...ain/java/org/opensearch/ad/model/ModelProfile.java 68.75% <0.00%> (+2.08%) ⬆️

@joshpalis joshpalis merged commit 68910ff into opensearch-project:feature/extensions Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants