Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Profile Test #748

Merged
merged 3 commits into from
Dec 6, 2022
+56 −0
Merged

Model Profile Test #748

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
158cc7a
Model Profile Test
vibrantvarun Dec 5, 2022
086eed9
Model Profile Test
vibrantvarun Dec 6, 2022
ba6ed41
Model Profile Test
vibrantvarun Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions src/test/java/org/opensearch/ad/model/ModelProfileTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
package org.opensearch.ad.model;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header:

Files with unapproved licenses:
> Task :licenseHeaders FAILED


  /Users/runner/work/anomaly-detection/anomaly-detection/src/test/java/org/opensearch/ad/model/ModelProfileTests.java
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK


import static org.opensearch.common.xcontent.XContentFactory.jsonBuilder;

import java.io.IOException;

import org.opensearch.ad.AbstractADTest;
import org.opensearch.ad.constant.CommonName;
import org.opensearch.common.Strings;
import org.opensearch.common.xcontent.ToXContent;
import org.opensearch.common.xcontent.XContentBuilder;

import test.org.opensearch.ad.util.JsonDeserializer;

public class ModelProfileTests extends AbstractADTest {

public void testToXContent() throws IOException {
ModelProfile profile1 = new ModelProfile(
randomAlphaOfLength(5),
Entity.createSingleAttributeEntity(randomAlphaOfLength(5), randomAlphaOfLength(5)),
0
owaiskazi19 marked this conversation as resolved.
Show resolved Hide resolved
);
XContentBuilder builder = jsonBuilder();
builder.startObject();
profile1.toXContent(builder, ToXContent.EMPTY_PARAMS);
builder.endObject();
String json = Strings.toString(builder);
assertTrue(JsonDeserializer.hasChildNode(json, CommonName.ENTITY_KEY));
assertFalse(JsonDeserializer.hasChildNode(json, CommonName.MODEL_SIZE_IN_BYTES));

ModelProfile profile2 = new ModelProfile(randomAlphaOfLength(5), null, 1);

builder = jsonBuilder();
builder.startObject();
profile2.toXContent(builder, ToXContent.EMPTY_PARAMS);
builder.endObject();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a method for the common code from 23-27 and 33-37?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can, working on it

json = Strings.toString(builder);

assertFalse(JsonDeserializer.hasChildNode(json, CommonName.ENTITY_KEY));
assertTrue(JsonDeserializer.hasChildNode(json, CommonName.MODEL_SIZE_IN_BYTES));

}
}