Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows CI for AD #703

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Conversation

amitgalitz
Copy link
Member

@amitgalitz amitgalitz commented Oct 27, 2022

Description

Adds windows CI for main branch

  1. Changed the usage of getPath() to first use .toURI() in some of the test cases. This is because just getting the path like we used to was returning a string like this: \C:\Sample\sample.txt. This isn't supported on Windows. Converting with toUri() works on all platforms.

Issues Resolved

resolves #274

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot opensearch-trigger-bot bot added backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Oct 27, 2022
Signed-off-by: Amit Galitzky <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #703 (80914a8) into main (7a05826) will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #703      +/-   ##
============================================
- Coverage     79.25%   78.79%   -0.47%     
+ Complexity     4255     4229      -26     
============================================
  Files           301      301              
  Lines         17872    17872              
  Branches       1897     1897              
============================================
- Hits          14165    14082      -83     
- Misses         2810     2888      +78     
- Partials        897      902       +5     
Flag Coverage Δ
plugin 78.79% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 81.76% <0.00%> (-3.96%) ⬇️
...c/main/java/org/opensearch/ad/util/ParseUtils.java 73.92% <0.00%> (-3.93%) ⬇️
...va/org/opensearch/ad/feature/SearchFeatureDao.java 82.84% <0.00%> (-3.85%) ⬇️
...rch/ad/transport/ForwardADTaskTransportAction.java 94.06% <0.00%> (-3.39%) ⬇️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 90.12% <0.00%> (-2.47%) ⬇️
...ain/java/org/opensearch/ad/model/ModelProfile.java 70.90% <0.00%> (-1.82%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 75.69% <0.00%> (-1.67%) ⬇️
...rch/ad/transport/AnomalyResultTransportAction.java 79.95% <0.00%> (-0.93%) ⬇️

@amitgalitz
Copy link
Member Author

This is currently failing because a change was made in main to now allow Opensearch to run as root user. This was reverted an hour with this PR: opensearch-project/OpenSearch#4949. Will try running CI again once validated this change is in latest snapshot

@amitgalitz amitgalitz marked this pull request as ready for review October 28, 2022 17:19
@amitgalitz amitgalitz requested a review from a team October 28, 2022 17:19
@amitgalitz
Copy link
Member Author

@ohltyler @jackiehanyang Lets merge this into main and then merge following backport PR. I will close the other windows-ci PR when this is merged and passing CI.

@ohltyler
Copy link
Member

Nice! LGTM. Just recommend changing the PR description from 2.x -> main

@ohltyler
Copy link
Member

Also, if you add closes or resolves keyword in front of the issue number it will automatically link to the PR

@ohltyler ohltyler linked an issue Oct 28, 2022 that may be closed by this pull request
2 tasks
@amitgalitz amitgalitz requested a review from ylwu-amzn October 28, 2022 18:43
@amitgalitz amitgalitz merged commit 06e5edb into opensearch-project:main Oct 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 06e5edb)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 06e5edb)
amitgalitz added a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 06e5edb)
amitgalitz added a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 06e5edb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.4 infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows Support
4 participants