-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows CI for AD #703
windows CI for AD #703
Conversation
Signed-off-by: Amit Galitzky <[email protected]>
e8975bb
to
a59b9f5
Compare
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
============================================
- Coverage 79.25% 78.79% -0.47%
+ Complexity 4255 4229 -26
============================================
Files 301 301
Lines 17872 17872
Branches 1897 1897
============================================
- Hits 14165 14082 -83
- Misses 2810 2888 +78
- Partials 897 902 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is currently failing because a change was made in main to now allow Opensearch to run as root user. This was reverted an hour with this PR: opensearch-project/OpenSearch#4949. Will try running CI again once validated this change is in latest snapshot |
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
@ohltyler @jackiehanyang Lets merge this into main and then merge following backport PR. I will close the other windows-ci PR when this is merged and passing CI. |
Nice! LGTM. Just recommend changing the PR description from |
Also, if you add |
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 06e5edb)
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 06e5edb)
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 06e5edb)
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 06e5edb)
Description
Adds windows CI for main branch
\C:\Sample\sample.txt
. This isn't supported on Windows. Converting withtoUri()
works on all platforms.Issues Resolved
resolves #274
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.