[Feature/extensions] Remove client #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
a team,
saratvemulapalli,
owaiskazi19 and
peternied
peternied
approved these changes
Jul 27, 2022
| @@ -1169,7 +1166,7 @@ private void detectAnomaly( | |||
| internalListener, | |||
| anomalyResults, | |||
| resultIndex, | |||
| () -> injectSecurity.close() | |||
| null | |||
There was a problem hiding this comment.
Can we remove this parameter?
There was a problem hiding this comment.
That was my initial gut feel, as this is the only known usage of that method so it possibly could be removed ...
But the method signature is more general with a CheckedRunnable<?> runBefore to support chaining result requests. In this particular usage, we aren't chaining a request, so null terminates the (potential) sequence of Runnables. I figured it does no harm to leave it as is.
saratvemulapalli
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all dependencies on the Common Utils Thread Context. It was initially used for users and roles, with most of the user code removed in #617. This cleans up the remaining (useless/unused) fetching of the thread context from the code.
The thread context was pulled from the ThreadPool, which is also no longer needed or desired in an extension and has been removed in most code.
There is still a remaining threadpool parameter in the
createComponents()method which inherits/overridesPluginand saves it as a field in the runner object, but it is okay to ignore that and not use it in later code; eventually that will no longer be needed. A thread pool is also part of theClientconstructor and there is athreadpool()getter from it. While it may be harmless to keep that method around I think having it throw an exception as unused, or be deprecated, would be preferable.Issues Resolved
Fixes opensearch-project/opensearch-sdk-java#22
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.