Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making default qualifier alpha1 in AD plugin #483

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Making default qualifier alpha1 in AD plugin

Issues Resolved

#432

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon requested a review from a team March 31, 2022 19:46
@peterzhuamazon peterzhuamazon self-assigned this Mar 31, 2022
@peterzhuamazon peterzhuamazon linked an issue Mar 31, 2022 that may be closed by this pull request
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 1.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Mar 31, 2022
ylwu-amzn
ylwu-amzn previously approved these changes Mar 31, 2022
amitgalitz
amitgalitz previously approved these changes Mar 31, 2022
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon dismissed stale reviews from amitgalitz and ylwu-amzn via a7631c1 March 31, 2022 20:13
@codecov-commenter
Copy link

Codecov Report

Merging #483 (565d8d3) into main (0ebb431) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 565d8d3 differs from pull request most recent head a7631c1. Consider uploading reports for the commit a7631c1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #483   +/-   ##
=========================================
  Coverage     78.15%   78.16%           
  Complexity     4157     4157           
=========================================
  Files           296      296           
  Lines         17652    17652           
  Branches       1877     1877           
=========================================
+ Hits          13796    13797    +1     
+ Misses         2961     2958    -3     
- Partials        895      897    +2     
Flag Coverage Δ
plugin 78.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ad/model/ModelProfile.java 69.09% <0.00%> (-1.82%) ⬇️
...opensearch/ad/indices/AnomalyDetectionIndices.java 71.93% <0.00%> (-0.19%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 82.21% <0.00%> (+0.45%) ⬆️

@peterzhuamazon peterzhuamazon merged commit 6ac9d71 into opensearch-project:main Mar 31, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-qualifier-fix branch March 31, 2022 20:47
@aksingh-es aksingh-es removed the infra Changes to infrastructure, testing, CI/CD, pipelines, etc. label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build version qualifiers.
5 participants