-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DCO Check Workflow #273
Add DCO Check Workflow #273
Conversation
6bd0c12
to
9e088e6
Compare
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
============================================
- Coverage 78.63% 78.62% -0.02%
- Complexity 3727 3728 +1
============================================
Files 276 276
Lines 15576 15576
Branches 1622 1622
============================================
- Hits 12248 12246 -2
- Misses 2607 2608 +1
- Partials 721 722 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - similar to frontend, let's wait for features to merge first before merging this.
@amitgalitz I think it's ok to merge this now |
Sounds good, will just rebase as good practice as its been awhile and merge once approved again |
e52ebe4
9e088e6
to
e52ebe4
Compare
Signed-off-by: Amit Galitzky <[email protected]>
e52ebe4
to
f88cca5
Compare
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Cool...can we close #256 ? |
Yes closing it. |
Signed-off-by: Amit Galitzky [email protected]
Description
Adding working flow to check whether commits are signed as per DCO.
Issues Resolved
#256
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.