Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCO Check Workflow #273

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

Adding working flow to check whether commits are signed as per DCO.

Issues Resolved

#256

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz requested review from kaituo and ohltyler October 26, 2021 17:02
@amitgalitz amitgalitz self-assigned this Oct 26, 2021
@amitgalitz amitgalitz removed their assignment Oct 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #273 (9e088e6) into main (04c48f5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
- Coverage     78.63%   78.62%   -0.02%     
- Complexity     3727     3728       +1     
============================================
  Files           276      276              
  Lines         15576    15576              
  Branches       1622     1622              
============================================
- Hits          12248    12246       -2     
- Misses         2607     2608       +1     
- Partials        721      722       +1     
Flag Coverage Δ
plugin 78.62% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ansport/handler/AnomalyResultBulkIndexHandler.java 85.71% <0.00%> (-4.09%) ⬇️
...rch/ad/transport/ForwardADTaskTransportAction.java 94.06% <0.00%> (-3.39%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 75.54% <0.00%> (-1.47%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 82.78% <0.00%> (+3.63%) ⬆️

kaituo
kaituo previously approved these changes Oct 28, 2021
@ohltyler ohltyler added the documentation Improvements or additions to documentation label Oct 29, 2021
ohltyler
ohltyler previously approved these changes Oct 29, 2021
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - similar to frontend, let's wait for features to merge first before merging this.

ylwu-amzn
ylwu-amzn previously approved these changes Nov 1, 2021
@ohltyler ohltyler added the v1.2.0 label Nov 2, 2021
@ohltyler
Copy link
Member

ohltyler commented Nov 8, 2021

@amitgalitz I think it's ok to merge this now

@amitgalitz
Copy link
Member Author

@amitgalitz I think it's ok to merge this now

Sounds good, will just rebase as good practice as its been awhile and merge once approved again

@amitgalitz amitgalitz dismissed stale reviews from ylwu-amzn, ohltyler, and kaituo via e52ebe4 November 8, 2021 19:36
@amitgalitz amitgalitz merged commit d02fb0a into opensearch-project:main Nov 8, 2021
@amitgalitz amitgalitz linked an issue Nov 8, 2021 that may be closed by this pull request
2 tasks
ohltyler pushed a commit to ohltyler/anomaly-detection-2 that referenced this pull request Nov 8, 2021
ohltyler pushed a commit that referenced this pull request Nov 9, 2021
@CEHENKLE
Copy link
Member

CEHENKLE commented Nov 9, 2021

Cool...can we close #256 ?

@amitgalitz
Copy link
Member Author

Cool...can we close #256 ?

Yes closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure DCO Workflow Check
6 participants