Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule validation in AnomalyDetector constructor #1341

Merged
merged 2 commits into from
Oct 18, 2024

address Amit's comments

fa55f65
Select commit
Loading
Failed to load commit list.
Merged

Add rule validation in AnomalyDetector constructor #1341

address Amit's comments
fa55f65
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

80.08% (+0.39%) compared to 2ab6dc7

View this Pull Request on Codecov

80.08% (+0.39%) compared to 2ab6dc7

Details

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.08%. Comparing base (2ab6dc7) to head (fa55f65).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/opensearch/ad/model/AnomalyDetector.java 95.91% 0 Missing and 2 partials ⚠️
...imeseries/transport/SuggestConfigParamRequest.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1341      +/-   ##
============================================
+ Coverage     79.68%   80.08%   +0.39%     
- Complexity     5630     5675      +45     
============================================
  Files           533      533              
  Lines         23410    23429      +19     
  Branches       2323     2335      +12     
============================================
+ Hits          18654    18762     +108     
+ Misses         3651     3563      -88     
+ Partials       1105     1104       -1     
Files with missing lines Coverage Δ
...main/java/org/opensearch/ad/ml/ADModelManager.java 79.25% <ø> (+3.15%) ⬆️
...ch/timeseries/ml/MemoryAwareConcurrentHashmap.java 84.61% <ø> (+53.18%) ⬆️
...ensearch/timeseries/model/ValidationIssueType.java 100.00% <100.00%> (ø)
...imeseries/transport/SuggestConfigParamRequest.java 92.59% <75.00%> (+54.13%) ⬆️
.../java/org/opensearch/ad/model/AnomalyDetector.java 88.99% <95.91%> (+2.65%) ⬆️

... and 14 files with indirect coverage changes