Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 2.x] Bump RCF Version and Fix Default Rules Bug in AnomalyDetector #1336

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Oct 11, 2024

Description

Backport 2ab6dc7 from #1334.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (1a8da83) to head (cdb0dcd).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1336      +/-   ##
============================================
+ Coverage     79.64%   79.88%   +0.24%     
- Complexity     5638     5658      +20     
============================================
  Files           533      533              
  Lines         23411    23411              
  Branches       2323     2323              
============================================
+ Hits          18646    18703      +57     
+ Misses         3663     3612      -51     
+ Partials       1102     1096       -6     
Flag Coverage Δ
plugin 79.88% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../java/org/opensearch/ad/model/AnomalyDetector.java 86.33% <100.00%> (ø)
...n/java/org/opensearch/timeseries/JobProcessor.java 82.78% <ø> (ø)
...ensearch/timeseries/ratelimit/ColdStartWorker.java 91.07% <100.00%> (ø)
...timeseries/rest/handler/IndexJobActionHandler.java 89.27% <ø> (+1.71%) ⬆️
...s/transport/handler/ResultBulkIndexingHandler.java 95.83% <100.00%> (+19.44%) ⬆️

... and 14 files with indirect coverage changes

…arch-project#1334)

* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
@kaituo kaituo merged commit 8b00904 into opensearch-project:2.x Oct 11, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants