feat: Adding support for date_nanos to Anomaly Detection #1238
Conversation
jehuty0shift
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
|
Hi, I'm new to contributing to this repository. I'm open to adding test to more meaningful places and/or to backport this feature to 2.x branch if needed. I will also PR the dashboard plugin when this PR get approved (knowing this PR surely needs more work done). |
|
@jehuty0shift Thanks a lot. Will review. |
| minPrecision.put("Scottsdale", 0.5); | ||
| Map<String, Double> minRecall = new HashMap<>(); | ||
| minRecall.put("Phoenix", 0.9); | ||
| minRecall.put("Scottsdale", 0.9); |
There was a problem hiding this comment.
I think it is changed to 0.6 in the main branch. Can you rebase?
There was a problem hiding this comment.
Hello, sure i have rebased and force-pushed the changes.
jehuty0shift
force-pushed
the
feature/date_nanos
branch
from
878cccc to
bab8599
Compare
Signed-off-by: Babacar Diasse <[email protected]>
jehuty0shift
force-pushed
the
feature/date_nanos
branch
from
bab8599 to
2a1cbb8
Compare
|
@jehuty0shift Once the CI passed, will approve and merge your PR. Please also work on a change on AD dashboard plugin side. I assume the date_nanos timestamp may not show in create/edit detector page. |
Signed-off-by: Babacar Diasse <[email protected]> (cherry picked from commit 60f99ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Yes, the PR to Anomaly Detection dashboard plugin will be done today. Thank you very much for your review ! Looking forward to contribute more to OpenSearch. |
(cherry picked from commit 60f99ab) Signed-off-by: Babacar Diasse <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR add support for date_nanos type for time field in Anomaly Detection.
Issues Resolved
#1226
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.