mds bug fixes #915
Merged
mds bug fixes #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
amitgalitz
approved these changes
Oct 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit d8f7380)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit d8f7380)
This was referenced Oct 25, 2024
jackiehanyang
added a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit d8f7380) Co-authored-by: Jackie Han <[email protected]>
jackiehanyang
added a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit d8f7380) Co-authored-by: Jackie Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr includes two mds bug fixes:
if (!dataSourceEnabled || (MDSOverviewState.selectedDataSourceId && MDSOverviewState.selectedDataSourceId !== ""))check to make sure when mds is enabled, we wait until the selected data source and selected data source id is ready before doing any dispatch calls. This saves us from seeing a transient error message says cannot get all detectors even though the page is actually functioning.Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.