merge feature/mds branch into main #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
dependencies
…oject#722) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>
…#728) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments in neo1 branch Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> * add MDS support on creation page Signed-off-by: Jackie Han <[email protected]> * updated methods to get data source query param from url Signed-off-by: Jackie Han <[email protected]> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <[email protected]> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <[email protected]> * update update call router Signed-off-by: Jackie Han <[email protected]> * update reducer and router Signed-off-by: Jackie Han <[email protected]> * clean up Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * update enums Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>
…arch-project#732) Signed-off-by: Jackie Han <[email protected]>
* working on ut Signed-off-by: Jackie Han <[email protected]> * update ut Signed-off-by: Jackie Han <[email protected]> * update UTs and add bug fixes Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
force-pushed
the
feature/mds
branch
from
4c7fbd5 to
9c2d584
Compare
owaiskazi19
approved these changes
Apr 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Support MDS on List, Detail, Dashboard, Overview pages (#722) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * add MDS support for detector creation&Update flow (#728) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments in neo1 branch Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> * add MDS support on creation page Signed-off-by: Jackie Han <[email protected]> * updated methods to get data source query param from url Signed-off-by: Jackie Han <[email protected]> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <[email protected]> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <[email protected]> * update update call router Signed-off-by: Jackie Han <[email protected]> * update reducer and router Signed-off-by: Jackie Han <[email protected]> * clean up Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * update enums Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * update actionOption attribution for all data soure components (#732) Signed-off-by: Jackie Han <[email protected]> * Add MDS UTs and bug fixes (#734) * working on ut Signed-off-by: Jackie Han <[email protected]> * update ut Signed-off-by: Jackie Han <[email protected]> * update UTs and add bug fixes Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * bug fixes (#737) Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 48acb93)
jackiehanyang
added a commit
that referenced
this pull request
Apr 29, 2024
* Support MDS on List, Detail, Dashboard, Overview pages (#722) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * add MDS support for detector creation&Update flow (#728) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments in neo1 branch Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> * add MDS support on creation page Signed-off-by: Jackie Han <[email protected]> * updated methods to get data source query param from url Signed-off-by: Jackie Han <[email protected]> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <[email protected]> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <[email protected]> * update update call router Signed-off-by: Jackie Han <[email protected]> * update reducer and router Signed-off-by: Jackie Han <[email protected]> * clean up Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * update enums Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * update actionOption attribution for all data soure components (#732) Signed-off-by: Jackie Han <[email protected]> * Add MDS UTs and bug fixes (#734) * working on ut Signed-off-by: Jackie Han <[email protected]> * update ut Signed-off-by: Jackie Han <[email protected]> * update UTs and add bug fixes Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * bug fixes (#737) Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 48acb93) Co-authored-by: Jackie Han <[email protected]>
kaituo
added a commit
to kaituo/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]>
1 task
kavilla
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]>
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d)
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d)
kavilla
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d) Co-authored-by: Kaituo Li <[email protected]>
kavilla
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d) Co-authored-by: Kaituo Li <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…ct#1257) This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr merges feature branch
feature/mdsinto main.It includes the following reviewed PRs:
Issues Resolved
#721
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.