Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate selected indices from query params on initial load #713

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Apr 1, 2024

Description

Previously, the selected indices in the URL query params was not getting assigned to the page state on initial load. This fixes that.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.31%. Comparing base (e9e178d) to head (aa32e4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   50.31%   50.31%   -0.01%     
==========================================
  Files         166      166              
  Lines        5593     5595       +2     
  Branches     1074     1075       +1     
==========================================
+ Hits         2814     2815       +1     
  Misses       2508     2508              
- Partials      271      272       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohltyler ohltyler merged commit e5cf2d8 into opensearch-project:main Apr 1, 2024
9 of 14 checks passed
@ohltyler ohltyler deleted the list-indices-fix branch April 1, 2024 16:56
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 1, 2024
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit e5cf2d8)
ohltyler added a commit that referenced this pull request Apr 1, 2024
)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit e5cf2d8)

Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants