Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build error due to missing babel plugins #661

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Dec 21, 2023

Description

Resolved
#658
#647

Should backport to 2.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c5a7e3) 50.31% compared to head (cf12753) 50.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files         166      166           
  Lines        5593     5593           
  Branches     1074     1057   -17     
=======================================
  Hits         2814     2814           
  Misses       2508     2508           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohltyler
Copy link
Member

I see builds are still failing with this, any idea?

Renaming artifact to $npm_package_config_plugin_zip_name-$npm_package_config_plugin_version.zip 
mv: cannot stat './build/$npm_package_config_plugin_name*.zip': No such file or directory
error Command failed with exit code 1.

@ruanyl
Copy link
Member Author

ruanyl commented Dec 27, 2023

Hi @ohltyler It only failed on windows, the same error is on main branch, doesn't look like relate to this PR.

@ohltyler ohltyler merged commit efb361b into opensearch-project:main Dec 27, 2023
9 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 27, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit efb361b)
ohltyler pushed a commit that referenced this pull request Dec 27, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit efb361b)

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants