Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontport main] Remove some styling overrides (#594) #595

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Sep 1, 2023

Description

Frontporting #594 to main

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler changed the title Remove some styling overrides (#594) [Frontport main] Remove some styling overrides (#594) Sep 1, 2023
@kaituo
Copy link
Collaborator

kaituo commented Sep 1, 2023

@ohltyler Could you help fix the failing tests?

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler
Copy link
Member Author

ohltyler commented Sep 5, 2023

@ohltyler Could you help fix the failing tests?

Looks to be entirely unrelated with these changes and was failing before this PR. I'll take a look

Signed-off-by: Tyler Ohlsen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #595 (2378596) into main (306f5fa) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   50.28%   50.28%           
=======================================
  Files         166      166           
  Lines        5590     5590           
  Branches     1055     1055           
=======================================
  Hits         2811     2811           
  Misses       2508     2508           
  Partials      271      271           

see 1 file with indirect coverage changes

@ohltyler
Copy link
Member Author

ohltyler commented Sep 5, 2023

@kaituo I've updated the failing unit tests.

@ohltyler ohltyler merged commit 8446fe4 into opensearch-project:main Sep 5, 2023
@ohltyler ohltyler deleted the oui-fixes-main branch September 5, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants