Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress workflow improvements #560

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Cypress workflow improvements #560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94c675
Update cypress test cmd to include vis augmenter tests
ohltyler Jul 18, 2023
7b77d52
Clean up refs
ohltyler Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/remote-integ-tests-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ on:
pull_request:
branches:
- "*"
env:
OPENSEARCH_DASHBOARDS_VERSION: 'main'
OPENSEARCH_DASHBOARDS_FTREPO_VERSION: 'main'
ANOMALY_DETECTION_PLUGIN_VERSION: 'main'
jobs:
test-without-security:
name: Run integ tests without security
Expand Down Expand Up @@ -41,7 +37,7 @@ jobs:
uses: actions/checkout@v2
with:
repository: opensearch-project/OpenSearch-Dashboards
ref: ${{ env.OPENSEARCH_DASHBOARDS_VERSION }}
ref: '${{ github.base_ref }}'
path: OpenSearch-Dashboards

- name: Checkout Anomaly Detection OpenSearch Dashboards plugin
Expand Down Expand Up @@ -71,7 +67,7 @@ jobs:
with:
path: anomaly-detection
repository: opensearch-project/anomaly-detection
ref: ${{ env.ANOMALY_DETECTION_PLUGIN_VERSION }}
ref: '${{ github.base_ref }}'

- name: Run OpenSearch with plugin
run: |
Expand Down Expand Up @@ -110,7 +106,7 @@ jobs:
with:
path: opensearch-dashboards-functional-test
repository: opensearch-project/opensearch-dashboards-functional-test
ref: ${{ env.OPENSEARCH_DASHBOARDS_FTREPO_VERSION }}
ref: '${{ github.base_ref }}'

- name: Get Cypress version
id: cypress_version
Expand All @@ -132,6 +128,6 @@ jobs:
uses: cypress-io/github-action@v2
with:
working-directory: opensearch-dashboards-functional-test
command: yarn run cypress run --env SECURITY_ENABLED=false --spec cypress/integration/plugins/anomaly-detection-dashboards-plugin/*.js
command: yarn run cypress run --env SECURITY_ENABLED=false --spec cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this skip existing specs like create_detector_spec.js as you only execute specs under anomaly-detection-dashboards-plugin's subdirectories?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they will be included along with any subdirectories - you can see that in the list of found specs in comment above

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your command in the comment has no .js:

yarn cypress:run-without-security --spec 'cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it still shows 11 w/ command:

  │ Specs:          11 found (plugins/anomaly-detection-dashboards-plugin/create_detector_spec.js, │
  │                  plugins/anomaly-detection-dashboards-plugin/dashboard_spec.js, plugins/anomal │
  │                 y-detection-dashboards-plugin/detector_configuration_spec.js, plugins/anomaly- │
  │                 detection-dashboards-pl...)

env:
CYPRESS_CACHE_FOLDER: ${{ matrix.cypress_cache_folder }}