Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a callout on flyout when association limit has been reached #524

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Adding a callout on flyout when association limit has been reached #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8620ad
adding a callout when association limit has been reached
amitgalitz Jul 6, 2023
4e703cc
fixed limit check and ran prettier
amitgalitz Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiFlyout,
EuiFlexItem,
EuiFlexGroup,
EuiCallOut,
} from '@elastic/eui';
import { get, isEmpty } from 'lodash';
import '../styles.scss';
Expand Down Expand Up @@ -45,6 +46,7 @@ import {
getAugmentVisSavedObjs,
} from '../../../../../../../src/plugins/vis_augmenter/public';
import { ASSOCIATED_DETECTOR_ACTION } from '../utils/constants';
import { PLUGIN_AUGMENTATION_MAX_OBJECTS_SETTING } from '../../../../../public/expressions/constants';

interface ConfirmModalState {
isOpen: boolean;
Expand Down Expand Up @@ -74,6 +76,8 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
const [detectorToUnlink, setDetectorToUnlink] = useState(
{} as DetectorListItem
);
const [associationLimitReached, setAssociationLimitReached] =
useState<boolean>(false);
const [confirmModalState, setConfirmModalState] = useState<ConfirmModalState>(
{
isOpen: false,
Expand All @@ -91,6 +95,9 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {

const uiSettings = getUISettings();
const notifications = getNotifications();
let maxAssociatedCount = uiSettings.get(
PLUGIN_AUGMENTATION_MAX_OBJECTS_SETTING
);

useEffect(() => {
if (
Expand Down Expand Up @@ -137,11 +144,19 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
getAugmentVisSavedObjs(embeddable.vis.id, savedObjectLoader, uiSettings)
.then((savedAugmentObjectsArr: any) => {
if (savedAugmentObjectsArr != undefined) {
if (maxAssociatedCount <= savedAugmentObjectsArr.length) {
setAssociationLimitReached(true);
} else {
setAssociationLimitReached(false);
}
const curSelectedDetectors = getAssociatedDetectors(
Object.values(allDetectors),
savedAugmentObjectsArr
);
setSelectedDetectors(curSelectedDetectors);
maxAssociatedCount = uiSettings.get(
PLUGIN_AUGMENTATION_MAX_OBJECTS_SETTING
);
setIsLoadingFinalDetectors(false);
}
})
Expand Down Expand Up @@ -295,6 +310,19 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
</h2>
</EuiTitle>
</EuiFlyoutHeader>
{associationLimitReached ? (
<EuiCallOut
title={`Limit reached. No more than ${maxAssociatedCount} objects can be associated with a visualization`}
style={{ margin: '16px' }}
size="s"
color="warning"
iconType="alert"
>
Adding more objects may affect cluster performance and prevent
dashboards from rendering properly. Remove associations before
adding new ones.
</EuiCallOut>
) : null}
<EuiFlyoutBody style={{ overflowY: 'auto' }}>
{confirmModalState.isOpen ? (
<ConfirmUnlinkDetectorModal
Expand All @@ -316,6 +344,7 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
<EuiButton
data-test-subj="associateDetectorButton"
fill
disabled={associationLimitReached}
iconType="link"
onClick={() => {
setMode('existing');
Expand Down
Loading