Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Add windows platform in CI workflow #335

Merged
merged 1 commit into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/unit-tests-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@ jobs:
name: Run unit tests
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
# Enable longer filenames for windows
- name: Enable longer filenames
if: ${{ matrix.os == 'windows-latest' }}
run: git config --system core.longpaths true
- name: Checkout OpenSearch Dashboards
uses: actions/checkout@v2
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ function NameAndDescription(props: NameAndDescriptionProps) {
{({ field, form }: FieldProps) => (
<FormattedFormRow
title="Name"
hint="Specify a unique and descriptive name that is easy to
recognize."
hint="Specify a unique and descriptive name that is easy to recognize."
isInvalid={isInvalid(field.name, form)}
error={getError(field.name, form)}
helpText={`Detector name must contain 1-64 characters. Valid characters are
Expand Down
10 changes: 4 additions & 6 deletions public/pages/DefineDetector/components/Settings/Settings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,9 @@ export const Settings = () => {
<FormattedFormRow
fullWidth
title="Detector interval"
hint="Define how often the detector collects data to generate
anomalies. The shorter the interval is, the more real time the
detector results will be, and the more computing resources the
detector will need."
hint={[
`Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.`
]}
hintLink={`${BASE_DOCS_LINK}/ad`}
isInvalid={isInvalid(field.name, form)}
error={getError(field.name, form)}
Expand Down Expand Up @@ -72,8 +71,7 @@ export const Settings = () => {
<FormattedFormRow
fullWidth
title="Window delay"
hint="Specify a window of delay for a detector to fetch data, if you
need to account for extra processing time."
hint="Specify a window of delay for a detector to fetch data, if you need to account for extra processing time."
hintLink={`${BASE_DOCS_LINK}/ad`}
isInvalid={isInvalid(field.name, form)}
error={getError(field.name, form)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ exports[`<Settings /> spec renders the component 1`] = `
>
<div
class="euiFormRow euiFormRow--fullWidth"
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hintlink="https://opensearch.org/docs/monitoring-plugins/ad"
id="random_html_id-row"
title="Detector interval"
Expand All @@ -80,7 +80,7 @@ exports[`<Settings /> spec renders the component 1`] = `
class="euiText euiText--medium sublabel"
style="max-width: 400px;"
>
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.

<a
class="euiLink euiLink--primary"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ exports[`<DefineDetector /> Full creating detector definition renders the compon
>
<div
class="euiFormRow euiFormRow--fullWidth"
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hintlink="https://opensearch.org/docs/monitoring-plugins/ad"
id="random_html_id-row"
title="Detector interval"
Expand All @@ -652,7 +652,7 @@ exports[`<DefineDetector /> Full creating detector definition renders the compon
class="euiText euiText--medium sublabel"
style="max-width: 400px;"
>
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.

<a
class="euiLink euiLink--primary"
Expand Down Expand Up @@ -1626,7 +1626,7 @@ exports[`<DefineDetector /> empty creating detector definition renders the compo
>
<div
class="euiFormRow euiFormRow--fullWidth"
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hintlink="https://opensearch.org/docs/monitoring-plugins/ad"
id="random_html_id-row"
title="Detector interval"
Expand All @@ -1650,7 +1650,7 @@ exports[`<DefineDetector /> empty creating detector definition renders the compo
class="euiText euiText--medium sublabel"
style="max-width: 400px;"
>
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.

<a
class="euiLink euiLink--primary"
Expand Down Expand Up @@ -2673,7 +2673,7 @@ exports[`<DefineDetector /> empty editing detector definition renders the compon
>
<div
class="euiFormRow euiFormRow--fullWidth"
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need."
hintlink="https://opensearch.org/docs/monitoring-plugins/ad"
id="random_html_id-row"
title="Detector interval"
Expand All @@ -2697,7 +2697,7 @@ exports[`<DefineDetector /> empty editing detector definition renders the compon
class="euiText euiText--medium sublabel"
style="max-width: 400px;"
>
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.
Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.

<a
class="euiLink euiLink--primary"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,7 @@ export function AnomalyDetectionOverview(props: AnomalyDetectionOverviewProps) {
<CreateWorkflowStepSeparator />
<CreateWorkflowStepDetails
title="2. Configure your detector"
content="Choose the fields in your index that you want to check for anomalies.
You may also set a category field to see a granular view of anomalies within each entity."
content="Choose the fields in your index that you want to check for anomalies. You may also set a category field to see a granular view of anomalies within each entity."
/>
<CreateWorkflowStepSeparator />
<CreateWorkflowStepDetails
Expand Down