Wait for detector to load before checking indices

[amitgalitz]

Signed-off-by: Amit Galitzky [email protected]

Description

Added two new conditions to two different useEffect calls on DetectorDetail page.
First change is to wait for getDetector request to finish loading before checking if the indices themselves exist. Currently we are checking if the indices exist on every change to the detector and while the detector is still loading it continuously loops this API call to check for indices. This then triggers a change in AppState which triggers the change in detector variable hence the loop.

The second change is under the same idea where we don't need to call the useEffect that calls on hideStopDetectorModal if the detector itself is empty.

Further improvements will be made in later PR to optimize useFetchDetectorInfo further which is the call updating the detector variable.

Issues Resolved

resolves #251

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #261 (2abbe19) into main (b25860d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   45.92%   45.93%   +0.01%     
==========================================
  Files         150      150              
  Lines        4956     4957       +1     
  Branches      968      969       +1     
==========================================
+ Hits         2276     2277       +1     
  Misses       2463     2463              
  Partials      217      217              

Impacted Files	Coverage Δ
...pages/DetectorDetail/containers/DetectorDetail.tsx	16.66% <0.00%> (+0.60%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25860d...2abbe19. Read the comment docs.