Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs bump #224

Closed
wants to merge 2 commits into from
Closed

Conversation

amitgalitz
Copy link
Member

@amitgalitz amitgalitz commented Apr 1, 2022

Description

  1. Version bumped 1.3 to 2.0
  2. added test environment that is now required for jest
  3. removed jest-dom and react dependency in AD as we are now using a more up to date version from OSD
  4. change wait() call to waitFor()
  5. AnnotationDomainTypes changed to AnnotationDomainType
  6. typescript upgrade made typing more restrictive so had to delete a line in get request which would make the body for get request undefined rather than null
  7. remove unused `showLegendsDisplayValue={false} line

This is a draft PR so others can track changes that have been made so far, there is still some issue regarding EuiPanel that makes tests fail. Still trying out best way to fix it in terms of UI. There were also a lot of snapshot updates that I want to go over and understand what has changed in UI.
This PR will be updated with more changes. More details on why specific changes have been made can be found here: opensearch-project/OpenSearch-Dashboards#1206

Huge kudos to @ananzh for all the help!!

Issues Resolved

resolves #221
resolves #222
resolves #164

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz added v2.0.0 Version 2.0.0 breaking labels Apr 1, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 1.x dependencies Pull requests that update a dependency file labels Apr 1, 2022
@amitgalitz
Copy link
Member Author

closing with more up to date PR that fixes some UI issueshttps://github.com//pull/230

@amitgalitz amitgalitz closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking dependencies Pull requests that update a dependency file v2.0.0 Version 2.0.0
Projects
None yet
1 participant