-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alerting with qualifier support in releases #366
Update alerting with qualifier support in releases #366
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@lezzago seems like your test is failing I am not sure if it is compatible with 2.0.0-alpha1 as of yet. Can you guys take a look on this? Thanks. |
We will submit a new pr later to fix those test issues since there are more 2.0 breaking changes |
This doesn't just look like test failures, it's failing to build with OpenSearch 2.0.0-alpha1. We should make the appropriate changes in this PR to fix compile issues, etc. @peterzhuamazon If you'd like to avoid that, you can just make the build qualifier changes here but keep using |
…ha1-SNAPSHOT Signed-off-by: Peter Zhu <[email protected]>
After talking to alerting team I will keep 2.0.0-SNAPSHOT for the time being to merge this PR. They will fix the compiling issues on alpha1 and add back. Thanks. |
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
============================================
- Coverage 79.15% 79.01% -0.14%
Complexity 268 268
============================================
Files 176 176
Lines 7286 7286
Branches 1016 1016
============================================
- Hits 5767 5757 -10
- Misses 994 1003 +9
- Partials 525 526 +1
Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <[email protected]>
Merge this as the security plugin is not available yet, so security checks expected to fail here. |
…t#366) * Update alerting with qualifier support in releases Signed-off-by: Peter Zhu <[email protected]> * Move snapshot above Signed-off-by: Peter Zhu <[email protected]> * Change to 2.0.0-SNAPSHOT until alerting fixed to compile on 2.0.0-alpha1-SNAPSHOT Signed-off-by: Peter Zhu <[email protected]> * Support qualifier for docker file pulling Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Angie Zhang <[email protected]>
Signed-off-by: Peter Zhu [email protected]
Issue #, if available:
#348
Description of changes:
Update alerting with qualifier support in releases
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.