[PR]Ensure Github workflow runs on docker image used by Production Distribution Build #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
added
enhancement
peterzhuamazon
changed the title
…bution Build Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
force-pushed
the
build-3966
branch
from
3260674 to
9a5dea2
Compare
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
|
Hi @getsaurabh02 @lezzago @AWSHurneyt @sbcd90 @eirsep I am not sure if the macos run and bwc run is stable, but my change should not affect those. Also, I remove the dco.yml as it has been replaced by the dco app for a long time. Thanks. |
AWSHurneyt
approved these changes
Oct 11, 2023
lezzago
approved these changes
Oct 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
…stribution Build (#1250) * Ensure Github workflow runs on docker image used by Production Distribution Build Signed-off-by: Peter Zhu <[email protected]> * Tweak spacing Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 2996611) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peterzhuamazon
pushed a commit
that referenced
this pull request
Oct 11, 2023
…stribution Build (#1250) (#1252) * Ensure Github workflow runs on docker image used by Production Distribution Build * Tweak spacing --------- (cherry picked from commit 2996611) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.