Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level for informative message #1218

Merged

Conversation

eht16
Copy link
Contributor

@eht16 eht16 commented Oct 3, 2023

Description of changes:
In org.opensearch.alerting.alerts/AlertIndices there is a log message "info deleteOldIndices" which is more of a trace but it is logged with level error.

In my logs see the following entries (repeated every 12 hours):

Oct  2 07:47:08 hostname opensearch[414]: [2023-10-02T07:47:08,760][ERROR][o.o.a.a.AlertIndices     ] [n1-name] info deleteOldIndices
Oct  2 07:47:08 hostname opensearch[414]: [2023-10-02T07:47:08,823][ERROR][o.o.a.a.AlertIndices     ] [n1-name] info deleteOldIndices
Oct  2 19:47:08 hostname opensearch[414]: [2023-10-02T19:47:08,761][ERROR][o.o.a.a.AlertIndices     ] [n1-name] info deleteOldIndices
Oct  2 19:47:08 hostname opensearch[414]: [2023-10-02T19:47:08,825][ERROR][o.o.a.a.AlertIndices     ] [n1-name] info deleteOldIndices

This is fine except the "info deleteOldIndices" which is logged as error but seems like an info or debug message.

Basically the same as in opensearch-project/security-analytics#203, I don't know if the code was copied or moved.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago merged commit 941d457 into opensearch-project:main Oct 5, 2023
13 of 15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Enrico Tröger <[email protected]>
(cherry picked from commit 941d457)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit that referenced this pull request May 17, 2024
(cherry picked from commit 941d457)

Signed-off-by: Enrico Tröger <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants