Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] add workflow type field exists check in search monitors action to return both workflows and monitors on search #1027

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 064e5f5 from #1026

…urn both workflows and monitors on search (#1026)

* add workflow type field exists check in search monitors action to retunr both workflows and monitors on search

Signed-off-by: Surya Sashank Nistala <[email protected]>

* remove .get() invocation on future and replace with suspendUntil call for search Associated monitors

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add workflowIds param in rest get alerts action

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 064e5f5)
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1027 (9919e19) into 2.9 (c2ab466) will increase coverage by 0.11%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##                2.9    #1027      +/-   ##
============================================
+ Coverage     72.69%   72.80%   +0.11%     
  Complexity      119      119              
============================================
  Files           160      160              
  Lines         10441    10448       +7     
  Branches       1572     1572              
============================================
+ Hits           7590     7607      +17     
+ Misses         1961     1952       -9     
+ Partials        890      889       -1     
Impacted Files Coverage Δ
...ch/alerting/transport/TransportGetMonitorAction.kt 87.05% <88.23%> (-0.13%) ⬇️

... and 7 files with indirect coverage changes

@eirsep eirsep merged commit aefb268 into 2.9 Jul 14, 2023
@github-actions github-actions bot deleted the backport/backport-1026-to-2.9 branch July 14, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants