-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 2.x Adds chained alerts (#976) #1007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chained alert triggers Signed-off-by: Surya Sashank Nistala <[email protected]> * converge all single node test cases Signed-off-by: Surya Sashank Nistala <[email protected]> * add license headers to files Signed-off-by: Surya Sashank Nistala <[email protected]> * fix workflow not found issue Signed-off-by: Surya Sashank Nistala <[email protected]> * added audit state alerts for doc level monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit alerts in query level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * temp: upload custom built common utils jar Signed-off-by: Surya Sashank Nistala <[email protected]> * fix get monitor response parsing to include associated_workflows Signed-off-by: Surya Sashank Nistala <[email protected]> * add query level monitor audit alerts tests Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit alerts in bucket level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * fix workflow tests Signed-off-by: Surya Sashank Nistala <[email protected]> * alerting Signed-off-by: Surya Sashank Nistala <[email protected]> * verify bucket monitor audit alerts and chained alerts in workflow Signed-off-by: Surya Sashank Nistala <[email protected]> * make execution id mandatory Signed-off-by: Surya Sashank Nistala <[email protected]> * revert mapping update in run job method Signed-off-by: Surya Sashank Nistala <[email protected]> * minor fixes in chained alert trigger result Signed-off-by: Surya Sashank Nistala <[email protected]> * fix chained alert triggers tests Signed-off-by: Surya Sashank Nistala <[email protected]> * fix acknowledge chained alert bug Signed-off-by: Surya Sashank Nistala <[email protected]> * revert get alerts change Signed-off-by: Surya Sashank Nistala <[email protected]> * refactor and remove transport actions being invoked in other transport actions Signed-off-by: Surya Sashank Nistala <[email protected]> * add license header Signed-off-by: Surya Sashank Nistala <[email protected]> * scheduled job mapping schema Signed-off-by: Surya Sashank Nistala <[email protected]> * fix ktlint and revert gradle dev set up chanegs Signed-off-by: Surya Sashank Nistala <[email protected]> * fix post delete method and refactor alert mover to add class level logger Signed-off-by: Surya Sashank Nistala <[email protected]> * fix test - pass workflow id in get alerts Signed-off-by: Surya Sashank Nistala <[email protected]> * remove monitor empty filter in get alerts api as there is dedicated api for fetching chained alerts - workflow alerts api Signed-off-by: Surya Sashank Nistala <[email protected]> * fix check for workflow id is empty or null in get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> * fix alert mover method delegate monitor parsing logic Signed-off-by: Surya Sashank Nistala <[email protected]> * remove common utils jar from repo Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
sbcd90
approved these changes
Jul 12, 2023
Signed-off-by: Surya Sashank Nistala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1007 +/- ##
============================================
- Coverage 75.27% 74.16% -1.11%
- Complexity 116 119 +3
============================================
Files 144 158 +14
Lines 8525 9460 +935
Branches 1225 1364 +139
============================================
+ Hits 6417 7016 +599
- Misses 1490 1749 +259
- Partials 618 695 +77
|
lezzago
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Adds chained alerts (#976) * chained alert triggers Signed-off-by: Surya Sashank Nistala <[email protected]> * converge all single node test cases Signed-off-by: Surya Sashank Nistala <[email protected]> * add license headers to files Signed-off-by: Surya Sashank Nistala <[email protected]> * fix workflow not found issue Signed-off-by: Surya Sashank Nistala <[email protected]> * added audit state alerts for doc level monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit alerts in query level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * temp: upload custom built common utils jar Signed-off-by: Surya Sashank Nistala <[email protected]> * fix get monitor response parsing to include associated_workflows Signed-off-by: Surya Sashank Nistala <[email protected]> * add query level monitor audit alerts tests Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit alerts in bucket level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * fix workflow tests Signed-off-by: Surya Sashank Nistala <[email protected]> * alerting Signed-off-by: Surya Sashank Nistala <[email protected]> * verify bucket monitor audit alerts and chained alerts in workflow Signed-off-by: Surya Sashank Nistala <[email protected]> * make execution id mandatory Signed-off-by: Surya Sashank Nistala <[email protected]> * revert mapping update in run job method Signed-off-by: Surya Sashank Nistala <[email protected]> * minor fixes in chained alert trigger result Signed-off-by: Surya Sashank Nistala <[email protected]> * fix chained alert triggers tests Signed-off-by: Surya Sashank Nistala <[email protected]> * fix acknowledge chained alert bug Signed-off-by: Surya Sashank Nistala <[email protected]> * revert get alerts change Signed-off-by: Surya Sashank Nistala <[email protected]> * refactor and remove transport actions being invoked in other transport actions Signed-off-by: Surya Sashank Nistala <[email protected]> * add license header Signed-off-by: Surya Sashank Nistala <[email protected]> * scheduled job mapping schema Signed-off-by: Surya Sashank Nistala <[email protected]> * fix ktlint and revert gradle dev set up chanegs Signed-off-by: Surya Sashank Nistala <[email protected]> * fix post delete method and refactor alert mover to add class level logger Signed-off-by: Surya Sashank Nistala <[email protected]> * fix test - pass workflow id in get alerts Signed-off-by: Surya Sashank Nistala <[email protected]> * remove monitor empty filter in get alerts api as there is dedicated api for fetching chained alerts - workflow alerts api Signed-off-by: Surya Sashank Nistala <[email protected]> * fix check for workflow id is empty or null in get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> * fix alert mover method delegate monitor parsing logic Signed-off-by: Surya Sashank Nistala <[email protected]> * remove common utils jar from repo Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> * fix imports Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit d2d03c6)
eirsep
added a commit
that referenced
this pull request
Jul 12, 2023
* Adds chained alerts (#976) * chained alert triggers Signed-off-by: Surya Sashank Nistala <[email protected]> * converge all single node test cases Signed-off-by: Surya Sashank Nistala <[email protected]> * add license headers to files Signed-off-by: Surya Sashank Nistala <[email protected]> * fix workflow not found issue Signed-off-by: Surya Sashank Nistala <[email protected]> * added audit state alerts for doc level monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit alerts in query level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * temp: upload custom built common utils jar Signed-off-by: Surya Sashank Nistala <[email protected]> * fix get monitor response parsing to include associated_workflows Signed-off-by: Surya Sashank Nistala <[email protected]> * add query level monitor audit alerts tests Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit alerts in bucket level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * fix workflow tests Signed-off-by: Surya Sashank Nistala <[email protected]> * alerting Signed-off-by: Surya Sashank Nistala <[email protected]> * verify bucket monitor audit alerts and chained alerts in workflow Signed-off-by: Surya Sashank Nistala <[email protected]> * make execution id mandatory Signed-off-by: Surya Sashank Nistala <[email protected]> * revert mapping update in run job method Signed-off-by: Surya Sashank Nistala <[email protected]> * minor fixes in chained alert trigger result Signed-off-by: Surya Sashank Nistala <[email protected]> * fix chained alert triggers tests Signed-off-by: Surya Sashank Nistala <[email protected]> * fix acknowledge chained alert bug Signed-off-by: Surya Sashank Nistala <[email protected]> * revert get alerts change Signed-off-by: Surya Sashank Nistala <[email protected]> * refactor and remove transport actions being invoked in other transport actions Signed-off-by: Surya Sashank Nistala <[email protected]> * add license header Signed-off-by: Surya Sashank Nistala <[email protected]> * scheduled job mapping schema Signed-off-by: Surya Sashank Nistala <[email protected]> * fix ktlint and revert gradle dev set up chanegs Signed-off-by: Surya Sashank Nistala <[email protected]> * fix post delete method and refactor alert mover to add class level logger Signed-off-by: Surya Sashank Nistala <[email protected]> * fix test - pass workflow id in get alerts Signed-off-by: Surya Sashank Nistala <[email protected]> * remove monitor empty filter in get alerts api as there is dedicated api for fetching chained alerts - workflow alerts api Signed-off-by: Surya Sashank Nistala <[email protected]> * fix check for workflow id is empty or null in get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> * fix alert mover method delegate monitor parsing logic Signed-off-by: Surya Sashank Nistala <[email protected]> * remove common utils jar from repo Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> * fix imports Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit d2d03c6) Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #976 to 2.x
chained alert triggers
converge all single node test cases
add license headers to files
fix workflow not found issue
added audit state alerts for doc level monitors
add audit alerts in query level monitor
temp: upload custom built common utils jar
fix get monitor response parsing to include associated_workflows
add query level monitor audit alerts tests
add audit alerts in bucket level monitor
fix workflow tests
alerting
verify bucket monitor audit alerts and chained alerts in workflow
make execution id mandatory
revert mapping update in run job method
minor fixes in chained alert trigger result
fix chained alert triggers tests
fix acknowledge chained alert bug
revert get alerts change
refactor and remove transport actions being invoked in other transport actions
add license header
scheduled job mapping schema
fix ktlint and revert gradle dev set up chanegs
fix post delete method and refactor alert mover to add class level logger
fix test - pass workflow id in get alerts
remove monitor empty filter in get alerts api as there is dedicated api for fetching chained alerts - workflow alerts api
fix check for workflow id is empty or null in get alerts action
fix alert mover method delegate monitor parsing logic
remove common utils jar from repo
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.