Bug fix and mds support for AD Plugin APIs #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn and
rishabhmaurya
as code owners
BionIT
approved these changes
Jun 3, 2024
AWSHurneyt
reviewed
Jun 4, 2024
There was a problem hiding this comment.
@riysaxen-amzn Changes LGTM. Looks like the developer signature check failed though.
riysaxen-amzn
force-pushed
the
bugFix
branch
2 times, most recently
from
a913006 to
22567de
Compare
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
signed off now |
AWSHurneyt
approved these changes
Jun 4, 2024
amsiglan
approved these changes
Jun 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* first setup for alerting MDS support Signed-off-by: Riya Saxena <[email protected]> * fixed some create-monitor issues Signed-off-by: Riya Saxena <[email protected]> * fixed create Monitor Signed-off-by: Riya Saxena <[email protected]> * fixed monitor actions for mds support Signed-off-by: Riya Saxena <[email protected]> * fix jest tests and added neo support for alertTriggers Signed-off-by: Riya Saxena <[email protected]> * minor bug fixes Signed-off-by: Riya Saxena <[email protected]> * minor bug fixes Signed-off-by: Riya Saxena <[email protected]> * featureAnywhere support Signed-off-by: Riya Saxena <[email protected]> * adPLugin changes Signed-off-by: Riya Saxena <[email protected]> * resolve merge conflict Signed-off-by: Riya Saxena <[email protected]> * feature anywhere updated Signed-off-by: Riya Saxena <[email protected]> * bug fix to clear the form when dataSource is changed Signed-off-by: Riya Saxena <[email protected]> * test fixed Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Riya <[email protected]> (cherry picked from commit 9c4dfb0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Jun 7, 2024
* first setup for alerting MDS support * fixed some create-monitor issues * fixed create Monitor * fixed monitor actions for mds support * fix jest tests and added neo support for alertTriggers * minor bug fixes * minor bug fixes * featureAnywhere support * adPLugin changes * resolve merge conflict * feature anywhere updated * bug fix to clear the form when dataSource is changed * test fixed --------- (cherry picked from commit 9c4dfb0) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Riya <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bugfix.mov
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.