Add verify binary installation workflow and add loose to bootstrapping #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
derek-ho
commented
Feb 23, 2024
| @@ -63,7 +63,7 @@ jobs: | |||
| - name: Bootstrap OpenSearch Dashboards with plugin | |||
| run: | | |||
| cd OpenSearch-Dashboards/plugins/alerting-dashboards-plugin | |||
| yarn osd bootstrap | |||
| yarn osd bootstrap --single-version=loose | |||
There was a problem hiding this comment.
More context here: opensearch-project/OpenSearch-Dashboards#5561
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 48.70% 48.69% -0.01%
==========================================
Files 236 236
Lines 6852 6845 -7
Branches 997 996 -1
==========================================
- Hits 3337 3333 -4
+ Misses 3512 3509 -3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
amsiglan
previously approved these changes
Mar 19, 2024
AWSHurneyt
reviewed
Mar 21, 2024
| @@ -42,7 +42,7 @@ jobs: | |||
| cd ./OpenSearch-Dashboards/ | |||
| su `id -un 1000` -c "source $NVM_DIR/nvm.sh && nvm use && node -v && yarn -v && | |||
| cd ./plugins/alerting-dashboards-plugin && | |||
| whoami && yarn osd bootstrap && yarn build && yarn run test:jest --coverage" | |||
| whoami && yarn osd bootstrap --single-version=loose && yarn build && yarn run test:jest --coverage" | |||
There was a problem hiding this comment.
Is the --single-version=loose argument also needed on line 87?
Signed-off-by: Derek Ho <[email protected]>
…rds-plugin into build-and-test-workflow
AWSHurneyt
approved these changes
Mar 22, 2024
…rds-plugin into build-and-test-workflow
lezzago
approved these changes
Apr 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
#891) * Add verify binary installation workflow and add loose to bootstrapping Signed-off-by: Derek Ho <[email protected]> * Fix built zip name Signed-off-by: Derek Ho <[email protected]> * Remove references to security Signed-off-by: Derek Ho <[email protected]> * Add loose Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 06fa155) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR. It also adds loose bootstrapping to resolve cypress conflicts after OSD added a dependency recently.
Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.