-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a bug impacting data filter configuration through the visual editor. #574
Conversation
Signed-off-by: AWSHurneyt <[email protected]>
…itor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]>
Created a separate PR to resolve the unit test failure, as it seems unrelated to these changes. |
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 52.86% 52.86%
=======================================
Files 212 212
Lines 5594 5594
Branches 782 782
=======================================
Hits 2957 2957
Misses 2635 2635
Partials 2 2 |
That PR was merged. Pulled those changes into the dev branch for this PR, and now the unit tests are passing. |
The cypress tests are expected to fail on |
…as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…itor. (#574) * Reduced flakiness of query monitor cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting data filter configuration through the visual editor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]> * Removed some test refactoring that were intended to reduce flakiness as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 18bdd05)
…itor. (#574) * Reduced flakiness of query monitor cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting data filter configuration through the visual editor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]> * Removed some test refactoring that were intended to reduce flakiness as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 18bdd05)
…itor. (#574) * Reduced flakiness of query monitor cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting data filter configuration through the visual editor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]> * Removed some test refactoring that were intended to reduce flakiness as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 18bdd05)
…itor. (#574) (#606) * Reduced flakiness of query monitor cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting data filter configuration through the visual editor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]> * Removed some test refactoring that were intended to reduce flakiness as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 18bdd05) Co-authored-by: AWSHurneyt <[email protected]>
…itor. (#574) (#607) * Reduced flakiness of query monitor cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting data filter configuration through the visual editor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]> * Removed some test refactoring that were intended to reduce flakiness as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 18bdd05) Co-authored-by: AWSHurneyt <[email protected]>
…itor. (#574) (#608) * Reduced flakiness of query monitor cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting data filter configuration through the visual editor. Added integration test. Signed-off-by: AWSHurneyt <[email protected]> * Removed some test refactoring that were intended to reduce flakiness as flakiness didn't improve. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 18bdd05) Co-authored-by: AWSHurneyt <[email protected]>
Hello This is impacting us on production: we cannot create new monitors (we are using Amazon OS version OpenSearch_2_7_R20230706). When could we expect this to be made available to upgrade to (I note your username has an AWS affilication, @AWSHurneyt - hope you have some insight). |
Hi @zakisaad , As a workaround, data filters can be configured using the
|
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.