Implemented support for >, >=, <, and <= query operators for the doc level monitor visual editor. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 53.39% 52.82% -0.57%
==========================================
Files 209 211 +2
Lines 5501 5569 +68
Branches 775 781 +6
==========================================
+ Hits 2937 2942 +5
- Misses 2562 2625 +63
Partials 2 2 see 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…level monitor visual editor. Signed-off-by: AWSHurneyt <[email protected]>
…etails. Signed-off-by: AWSHurneyt <[email protected]>
…r more details." This fix will be implemented in a separate PR. This reverts commit 3a1e8b1. Signed-off-by: AWSHurneyt <[email protected]>
lezzago
reviewed
Apr 4, 2023
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
lezzago
previously approved these changes
Apr 10, 2023
amsiglan
reviewed
Apr 12, 2023
public/pages/CreateMonitor/components/DocumentLevelMonitorQueries/DocumentLevelQuery.js
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Apr 12, 2023
public/pages/CreateMonitor/components/DocumentLevelMonitorQueries/utils/helpers.js
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Apr 12, 2023
Signed-off-by: AWSHurneyt <[email protected]>
…tests to a more appropriate location. Signed-off-by: AWSHurneyt <[email protected]>
…lemented related unit tests. Signed-off-by: AWSHurneyt <[email protected]>
lezzago
approved these changes
Apr 17, 2023
amsiglan
approved these changes
Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…level monitor visual editor. (#508) * Implemented support for >, >=, <, and <= query operators for the doc level monitor visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug with doc level trigger creation. See issue 448 for more details. Signed-off-by: AWSHurneyt <[email protected]> * Revert "Fixed a bug with doc level trigger creation. See issue 448 for more details." This fix will be implemented in a separate PR. This reverts commit 3a1e8b1. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug involving the parsing of query operators. Signed-off-by: AWSHurneyt <[email protected]> * Implemented cypress tests to validate all support query operators. Signed-off-by: AWSHurneyt <[email protected]> * Renamed function based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored validation method to be more succinct. Moved related unit tests to a more appropriate location. Signed-off-by: AWSHurneyt <[email protected]> * Refactored validation method to check whether input value is NaN. Implemented related unit tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 6089ad9)
AWSHurneyt
added a commit
that referenced
this pull request
Apr 17, 2023
…level monitor visual editor. (#508) (#528) * Implemented support for >, >=, <, and <= query operators for the doc level monitor visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug with doc level trigger creation. See issue 448 for more details. Signed-off-by: AWSHurneyt <[email protected]> * Revert "Fixed a bug with doc level trigger creation. See issue 448 for more details." This fix will be implemented in a separate PR. This reverts commit 3a1e8b1. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug involving the parsing of query operators. Signed-off-by: AWSHurneyt <[email protected]> * Implemented cypress tests to validate all support query operators. Signed-off-by: AWSHurneyt <[email protected]> * Renamed function based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored validation method to be more succinct. Moved related unit tests to a more appropriate location. Signed-off-by: AWSHurneyt <[email protected]> * Refactored validation method to check whether input value is NaN. Implemented related unit tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 6089ad9) Co-authored-by: AWSHurneyt <[email protected]>
4 tasks
mjsell1234
pushed a commit
to mjsell1234/alerting-dashboards-plugin
that referenced
this pull request
Jun 14, 2023
…level monitor visual editor. (opensearch-project#508) * Implemented support for >, >=, <, and <= query operators for the doc level monitor visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug with doc level trigger creation. See issue 448 for more details. Signed-off-by: AWSHurneyt <[email protected]> * Revert "Fixed a bug with doc level trigger creation. See issue 448 for more details." This fix will be implemented in a separate PR. This reverts commit 3a1e8b1. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug involving the parsing of query operators. Signed-off-by: AWSHurneyt <[email protected]> * Implemented cypress tests to validate all support query operators. Signed-off-by: AWSHurneyt <[email protected]> * Renamed function based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored validation method to be more succinct. Moved related unit tests to a more appropriate location. Signed-off-by: AWSHurneyt <[email protected]> * Refactored validation method to check whether input value is NaN. Implemented related unit tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
>,>=,<, and<=query operators for the doc level monitor visual editor.Issues Resolved
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.