-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip overriding routing table when it already contains entries with remote recovery source #9962
skip overriding routing table when it already contains entries with remote recovery source #9962
Conversation
db2a2b1
to
a0f8c87
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 742ff75 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/cluster/routing/RoutingTable.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
98a6bf3
to
7d21740
Compare
Gradle Check (Jenkins) Run Completed with:
|
Test Failuresorg.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries Ran locally as well with 10 iterations. all tests are passing. Only testCloneAfterRepoShallowSettingDisabled failed once out of 10
10 tests completed, 1 failed |
…emote recovery source Signed-off-by: bansvaru <[email protected]>
…Ts to cover new cases Signed-off-by: bansvaru <[email protected]>
Signed-off-by: bansvaru <[email protected]>
b39d173
to
257afe3
Compare
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/index/recovery/RemoteStoreRestoreService.java
Show resolved
Hide resolved
In case you do this how will you identify it is local shard vs remote shard as you are doing it based on source? is there other way to identify the same? |
We would identify just based on index setting and the check for recovery source will be removed. Current code is more safe IMO. But we should think about the other approach and handle this for remote store more holistically by testing other scenarios as well like recovery from local disk etc Created an issue for testing and fix the local disk recovery for Remote Indices #10071 . |
Signed-off-by: bansvaru <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: bansvaru <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: bansvaru <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
…emote recovery source (#9962) * skip overriding routing table when it already contains entries with remote recovery source Signed-off-by: bansvaru <[email protected]> (cherry picked from commit 5fdd418) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…emote recovery source (#9962) * skip overriding routing table when it already contains entries with remote recovery source Signed-off-by: bansvaru <[email protected]> (cherry picked from commit 5fdd418) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…emote recovery source (#9962) (#10084) * skip overriding routing table when it already contains entries with remote recovery source (cherry picked from commit 5fdd418) Signed-off-by: bansvaru <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…emote recovery source (opensearch-project#9962) * skip overriding routing table when it already contains entries with remote recovery source Signed-off-by: bansvaru <[email protected]>
…emote recovery source (#9962) (#10083) * skip overriding routing table when it already contains entries with remote recovery source (cherry picked from commit 5fdd418) Signed-off-by: bansvaru <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…emote recovery source (opensearch-project#9962) * skip overriding routing table when it already contains entries with remote recovery source Signed-off-by: bansvaru <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
…emote recovery source (opensearch-project#9962) * skip overriding routing table when it already contains entries with remote recovery source Signed-off-by: bansvaru <[email protected]>
…emote recovery source (opensearch-project#9962) * skip overriding routing table when it already contains entries with remote recovery source Signed-off-by: bansvaru <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
GatewayService.RecoverStateUpdateTask
which performs various mutations to the cluster state.GatewayService.RecoverStateUpdateTask
overriding the pre-generated routing table entries for remote store clusters we have skipped the routing table override.Related Issues
Resolves #9921
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.