Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Michael Froh as a maintainer #9463

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

andrross
Copy link
Member

Description

Michael has graciously accepted our invitation to become a maintainer. Welcome, Michael!

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #9463 (c316bc3) into main (ebdffbb) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9463      +/-   ##
============================================
+ Coverage     71.20%   71.25%   +0.04%     
- Complexity    57474    57551      +77     
============================================
  Files          4776     4776              
  Lines        270815   270815              
  Branches      39584    39584              
============================================
+ Hits         192835   192962     +127     
+ Misses        61741    61673      -68     
+ Partials      16239    16180      -59     

see 465 files with indirect coverage changes

@kotwanikunal
Copy link
Member

We can retry checks post #9486

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@andrross andrross added the backport 2.x Backport to 2.x branch label Aug 23, 2023
@andrross andrross merged commit 89ccda9 into opensearch-project:main Aug 23, 2023
@andrross andrross deleted the froh-maintainer branch August 23, 2023 20:45
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9463-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89ccda9a3a0f8120c0a701094c759d55288bd0bd
# Push it to GitHub
git push --set-upstream origin backport/backport-9463-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9463-to-2.x.

neetikasinghal pushed a commit to neetikasinghal/OpenSearch that referenced this pull request Aug 23, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
andrross added a commit to andrross/OpenSearch that referenced this pull request Aug 28, 2023
Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 89ccda9)
reta pushed a commit that referenced this pull request Aug 28, 2023
Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 89ccda9)
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants