-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test InternalEngineTests.testLastRefreshCheckpoint #9365
Conversation
Signed-off-by: Ankit Kala <[email protected]>
Compatibility status:Checks if related components are compatible with change 0a7eade Incompatible componentsIncompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9365 +/- ##
============================================
- Coverage 71.15% 71.15% -0.01%
- Complexity 57452 57463 +11
============================================
Files 4777 4777
Lines 270705 270706 +1
Branches 39565 39565
============================================
- Hits 192629 192619 -10
- Misses 61909 61923 +14
+ Partials 16167 16164 -3
|
Signed-off-by: Ankit Kala <[email protected]> (cherry picked from commit f971e5b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…9395) (cherry picked from commit f971e5b) Signed-off-by: Ankit Kala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch-project#9365) Signed-off-by: Ankit Kala <[email protected]>
…rch-project#9365) Signed-off-by: Ankit Kala <[email protected]> Signed-off-by: Kiran Reddy <[email protected]>
…rch-project#9365) Signed-off-by: Ankit Kala <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…rch-project#9365) Signed-off-by: Ankit Kala <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
…rch-project#9365) Signed-off-by: Ankit Kala <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
We saw an assertion failure here where
currentOngoingRefreshCheckpoint
was-1
andlastRefreshedCheckpoint
was0
. This was not reproducible after 50K test iterations.Within the
LastRefreshedCheckpointListener
(here) we always updatelastRefreshedCheckpoint
based oncurrentOngoingRefreshCheckpoint
so this above failure condition can never occur. Except we're also invoking theupdateRefreshedCheckpoint
from refresh which isn't required IMO. Ideal fix would be to remove that but that is more intrusive and there isn't enough context on why it was added in the first place.Thus the easier fix in this PR is to ensure that we also update
pendingCheckpoint
whenever we're updatingrefreshedCheckpoint
to ensure consistency.Related Issues
Resolves #9029
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.