Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] JodaCompatibleZonedDateTime #9355

Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Aug 15, 2023

This PR removes the JodaCompatibleZonedDateTime class and tests in favor of Java time. This class has long been deprecated since Legacy 7.0. Removing this class is more of a formality and cleanup and does not break wire BWC.

dependency of #9350
relates #5910
relates #8110

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 36m 45s

@nknize nknize force-pushed the removeJodaCompatibleZonedDateTime branch from 6481daf to 8969d2d Compare August 15, 2023 17:55
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 27m 10s

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git]
Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 27m 14s

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 23fd9a5

Incompatible components

Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #9355 (19e283b) into main (8255050) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 20.00%.

❗ Current head 19e283b differs from pull request most recent head 2eb907b. Consider uploading reports for the commit 2eb907b to get more accurate results

@@            Coverage Diff             @@
##               main    #9355    +/-   ##
==========================================
  Coverage     71.13%   71.14%            
+ Complexity    57473    57357   -116     
==========================================
  Files          4777     4776     -1     
  Lines        270822   270594   -228     
  Branches      39586    39553    -33     
==========================================
- Hits         192659   192518   -141     
+ Misses        61941    61905    -36     
+ Partials      16222    16171    -51     
Files Changed Coverage Δ
...n/java/org/opensearch/painless/AnalyzerCaster.java 76.54% <ø> (-0.28%) ⬇️
...ess/src/main/java/org/opensearch/painless/Def.java 74.06% <ø> (-0.14%) ⬇️
...ain/java/org/opensearch/painless/MethodWriter.java 87.09% <ø> (+0.19%) ⬆️
...src/main/java/org/opensearch/painless/Utility.java 100.00% <ø> (ø)
.../java/org/opensearch/painless/WriterConstants.java 97.84% <ø> (-0.05%) ⬇️
...java/org/opensearch/painless/api/Augmentation.java 84.61% <0.00%> (-0.33%) ⬇️
...h/common/xcontent/XContentOpenSearchExtension.java 88.52% <ø> (+1.02%) ⬆️
...rg/opensearch/index/fielddata/ScriptDocValues.java 47.61% <0.00%> (ø)
...n/java/org/opensearch/script/ScoreScriptUtils.java 1.73% <ø> (ø)
...ggregations/support/values/ScriptDoubleValues.java 52.00% <ø> (+11.61%) ⬆️
... and 2 more

... and 586 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Aug 15, 2023

Unrelated failure:

./gradlew ':server:internalClusterTest' --tests "org.opensearch.remotestore.SegmentReplicationWithRemoteStorePressureIT.testAddReplicaWhileWritesBlocked" -Dtests.seed=4C7BC54909069BB6 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-Latn-ME -Dtests.timezone=AGT -Druntime.java=20
java.lang.AssertionError: timed out waiting for green state

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize force-pushed the removeJodaCompatibleZonedDateTime branch from 8969d2d to 80e7045 Compare August 15, 2023 20:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

This commit removes the JodaCompatibleZonedDateTime class and tests in
favor of Java time.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize force-pushed the removeJodaCompatibleZonedDateTime branch from 80e7045 to 2eb907b Compare August 16, 2023 20:50
@nknize nknize added stalled Issues that have stalled needs-review Label for PRs seeking review. labels Aug 16, 2023
@nknize
Copy link
Collaborator Author

nknize commented Aug 16, 2023

Flagging as needs review....

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.translog.RemoteFSTranslogTests.testSimpleOperationsUpload

@andrross andrross merged commit f3957ea into opensearch-project:main Aug 16, 2023
12 of 17 checks passed
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
This commit removes the JodaCompatibleZonedDateTime class and tests in
favor of Java time.

Signed-off-by: Nicholas Walter Knize <[email protected]>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
This commit removes the JodaCompatibleZonedDateTime class and tests in
favor of Java time.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Kiran Reddy <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
This commit removes the JodaCompatibleZonedDateTime class and tests in
favor of Java time.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
This commit removes the JodaCompatibleZonedDateTime class and tests in
favor of Java time.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
This commit removes the JodaCompatibleZonedDateTime class and tests in
favor of Java time.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility enhancement Enhancement or improvement to existing feature or request needs-review Label for PRs seeking review. pending backport Identifies an issue or PR that still needs to be backported skip-changelog stalled Issues that have stalled v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants